Change 'Add Page' to show a simple input dialog with --use-more-webui.

chrome/browser/bookmarks/bookmark_input_window_dialog_controller.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_INPUT_WINDOW_DIALOG_CONTROLLER_H_
+#define CHROME_BROWSER_BOOKMARKS_BOOKMARK_INPUT_WINDOW_DIALOG_CONTROLLER_H_
+#pragma once
+
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "chrome/browser/bookmarks/base_bookmark_model_observer.h"
+#include "chrome/browser/ui/input_window_dialog.h"
+#include "ui/gfx/native_widget_types.h"
+
+class Profile;
+
+// BookmarkInputWindowDialogController manages the editing and/or creation of a
+// bookmark page or a bookmark folder. If the user presses ok, the name change
+// is committed to the model.
+//
+// BookmarkInputWindowDialogController deletes itself when the window is closed.
+class BookmarkInputWindowDialogController : public InputWindowDialog::Delegate,
+                                            public BaseBookmarkModelObserver {
+ public:
+  enum Type {

[flackr, 2011/11/02 15:38:18]

BookmarkEditor::EditDetails already encapsulates this information. You should
make use of this class to pass the type and node information.

[mazda, 2011/11/07 09:59:23]

Deleted this enum.

+    NEW_BOOKMARK_PAGE,  // Creates a new bookmark page.
+    NEW_BOOKMARK_FOLDER,  // Creates a new bookmark folder.
+    EXISTING_BOOKMARK_PAGE,  // Modifies an existing bookmark page.
+    EXISTING_BOOKMARK_FOLDER,  // Renames an existing bookmark folder.
+  };
+
+  virtual ~BookmarkInputWindowDialogController();
+
+  static void Show(Profile* profile,

[flackr, 2011/11/02 15:38:18]

Avoid exposing a public method which takes arguments which are only relevant for
certain operations (i.e. index only relevant for NEW_BOOKMARK_*). Ideally you
can take in BookmarkEditor::EditDetails and get all of the relevant information
from this structure.

[mazda, 2011/11/07 09:59:23]

I added index to BookmarkEditor::EditaDetails and deleted index argument from
this function.

+                   gfx::NativeWindow wnd,
+                   const BookmarkNode* node,
+                   int index,
+                   Type type);
+
+ private:
+  BookmarkInputWindowDialogController(Profile* profile,
+                                      gfx::NativeWindow wnd,
+                                      const BookmarkNode* node,
+                                      int index,
+                                      Type type);
+
+  // InputWindowDialog::Delegate:
+  virtual bool IsValid(const InputWindowDialog::InputTexts& texts) OVERRIDE;
+  virtual void InputAccepted(
+      const InputWindowDialog::InputTexts& texts) OVERRIDE;
+  virtual void InputCanceled() OVERRIDE;
+
+  // BaseBookmarkModelObserver:
+  virtual void BookmarkModelChanged() OVERRIDE;
+  virtual void BookmarkModelBeingDeleted(BookmarkModel* model) OVERRIDE;
+
+  Profile* profile_;
+
+  BookmarkModel* model_;
+
+  // If |is_new_| is true, this is the parent to create the new node under.
+  // Otherwise this is the node to change the title of.
+  const BookmarkNode* node_;
+
+  // Index to insert the new folder at.
+  int index_;
+
+  Type type_;
+
+  InputWindowDialog* dialog_;
+
+  DISALLOW_COPY_AND_ASSIGN(BookmarkInputWindowDialogController);
+};
+
+#endif  // CHROME_BROWSER_BOOKMARKS_BOOKMARK_INPUT_WINDOW_DIALOG_CONTROLLER_H_