Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 8438024: Revert 107679 - Broke https for appspot.com - http://crbug.com/102507 (Closed)

Created:
9 years, 1 month ago by Ryan Sleevi
Modified:
9 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 107679 - Broke https for appspot.com - http://crbug.com/102507 Disallow wildcards from matching top-level registry controlled domains during cert validation. BUG=100442 TEST=net_unittests:X509CertificateNameVerifyTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107075 Review URL: http://codereview.chromium.org/8362023 TBR=rsleevi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -41 lines) Patch
M net/base/x509_certificate.cc View 2 chunks +6 lines, -26 lines 0 comments Download
M net/base/x509_certificate_unittest.cc View 3 chunks +4 lines, -15 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ryan Sleevi
9 years, 1 month ago (2011-11-02 00:57:48 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698