Cloud print connector policy.

chrome/browser/browser_process_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_process_impl.h"
 
 #include <map>
 #include <set>
 #include <vector>
 
@@ skipping 27 matching lines @@
 #include "chrome/browser/metrics/thread_watcher.h"
 #include "chrome/browser/net/chrome_net_log.h"
 #include "chrome/browser/net/crl_set_fetcher.h"
 #include "chrome/browser/net/sdch_dictionary_fetcher.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/policy/browser_policy_connector.h"
 #include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/prerender/prerender_tracker.h"
 #include "chrome/browser/printing/background_printing_manager.h"
+#include "chrome/browser/printing/cloud_print/cloud_print_proxy_service.h"
+#include "chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h"
 #include "chrome/browser/printing/print_job_manager.h"
 #include "chrome/browser/printing/print_preview_tab_controller.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "chrome/browser/shell_integration.h"
 #include "chrome/browser/sidebar/sidebar_manager.h"
 #include "chrome/browser/status_icons/status_tray.h"
 #include "chrome/browser/tab_closeable_state_watcher.h"
 #include "chrome/browser/tab_contents/thumbnail_generator.h"
@@ skipping 19 matching lines @@
 #include "content/browser/download/download_status_updater.h"
 #include "content/browser/download/mhtml_generation_manager.h"
 #include "content/browser/download/save_file_manager.h"
 #include "content/browser/gpu/gpu_process_host_ui_shim.h"
 #include "content/browser/net/browser_online_state_observer.h"
 #include "content/browser/plugin_service.h"
 #include "content/browser/renderer_host/render_process_host.h"
 #include "content/browser/renderer_host/resource_dispatcher_host.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_details.h"
+#include "content/public/browser/notification_service.h"
 #include "content/public/common/url_fetcher.h"
 #include "ipc/ipc_logging.h"
 #include "net/socket/client_socket_pool_manager.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "ui/base/clipboard/clipboard.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "webkit/plugins/npapi/plugin_list.h"
 
 #if defined(OS_WIN)
 #include "views/focus/view_storage.h"
@@ skipping 586 matching lines @@
                                  const content::NotificationSource& source,
                                  const content::NotificationDetails& details) {
   if (type == chrome::NOTIFICATION_PREF_CHANGED) {
     std::string* pref = content::Details<std::string>(details).ptr();
     if (*pref == prefs::kDefaultBrowserSettingEnabled) {
       ApplyDefaultBrowserPolicy();
     } else if (*pref == prefs::kDisabledSchemes) {
       ApplyDisabledSchemesPolicy();
     } else if (*pref == prefs::kAllowCrossOriginAuthPrompt) {
       ApplyAllowCrossOriginAuthPromptPolicy();
+    } else if (*pref == prefs::kCloudPrintProxyEnabled) {
+      ApplyCloudPrintConnectorPolicy();
+    }
+  } else if (type == chrome::NOTIFICATION_PROFILE_CREATED) {

[Peter Kasting, 2011/11/02 22:09:59]

Nit: I would either do:

if (type == chrome::NOTIFICATION_PREF_CHANGED) {
  ...
  return;
}
DCHECK_EQ(chrome::NOTIFICATION_PROFILE_CREATED);
...

or else

switch (type) {
  case chrome::NOTIFICATION_PREF_CHANGED:
    ...;
    break;

  case chrome::NOTIFICATION_PROFILE_CREATED:
    ...;
    break;

  default:
    NOTREACHED();
}

+    if (local_state()->IsManagedPreference(prefs::kCloudPrintProxyEnabled)) {
+      Profile* profile = content::Source<Profile>(source).ptr();
+      if (profile)

[Peter Kasting, 2011/11/02 22:09:59]

Can this ever be NULL?  If not then don't add a conditional here.

+        ApplyCloudPrintConnectorPolicyToProfile(profile);
     }
   } else {
     NOTREACHED();
   }
 }
 
 #if (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS)
 void BrowserProcessImpl::StartAutoupdateTimer() {
   autoupdate_timer_.Start(FROM_HERE,
       base::TimeDelta::FromHours(kUpdateCheckIntervalHours),
@@ skipping 261 matching lines @@
   int max_per_proxy = local_state_->GetInteger(prefs::kMaxConnectionsPerProxy);
   net::ClientSocketPoolManager::set_max_sockets_per_proxy_server(
       std::max(std::min(max_per_proxy, 99),
                net::ClientSocketPoolManager::max_sockets_per_group()));
 
   // This is observed by ChildProcessSecurityPolicy, which lives in content/
   // though, so it can't register itself.
   local_state_->RegisterListPref(prefs::kDisabledSchemes);
   pref_change_registrar_.Add(prefs::kDisabledSchemes, this);
   ApplyDisabledSchemesPolicy();
+
+  local_state_->RegisterBooleanPref(prefs::kCloudPrintProxyEnabled, true);
+  pref_change_registrar_.Add(prefs::kCloudPrintProxyEnabled, this);
+  notification_registrar_.Add(
+      this, chrome::NOTIFICATION_PROFILE_CREATED,

[Peter Kasting, 2011/11/02 22:09:59]

Nit: These args can go on the prior line

+      content::NotificationService::AllBrowserContextsAndSources());
 }
 
 void BrowserProcessImpl::CreateIconManager() {
   DCHECK(!created_icon_manager_ && icon_manager_.get() == NULL);
   created_icon_manager_ = true;
   icon_manager_.reset(new IconManager);
 }
 
 void BrowserProcessImpl::CreateDevToolsManager() {
   DCHECK(devtools_manager_.get() == NULL);
@@ skipping 82 matching lines @@
         set_browser_worker = new ShellIntegration::DefaultBrowserWorker(NULL);
     set_browser_worker->StartSetAsDefault();
   }
 }
 
 void BrowserProcessImpl::ApplyAllowCrossOriginAuthPromptPolicy() {
   bool value = local_state()->GetBoolean(prefs::kAllowCrossOriginAuthPrompt);
   resource_dispatcher_host()->set_allow_cross_origin_auth_prompt(value);
 }
 
+void BrowserProcessImpl::ApplyCloudPrintConnectorPolicy() {
+  // Search the profiles for any enabled connectors and shut them down.
+  ProfileManager* pm = profile_manager();

[Peter Kasting, 2011/11/02 22:09:59]

Nit: Could just roll this into the next line

+  std::vector<Profile*> profiles(pm->GetLoadedProfiles());
+  for (size_t i = 0; i < profiles.size(); ++i)

[Peter Kasting, 2011/11/02 22:09:59]

Nit: I suggest using an iterator (rest of this file seems to generally prefer
iterators to indexes where possible).  Feel free to add a typedef for
vector<Profile*> to profile_manager.h if it makes life easier.

+    ApplyCloudPrintConnectorPolicyToProfile(profiles[i]);
+}
+
+void BrowserProcessImpl::ApplyCloudPrintConnectorPolicyToProfile(
+    Profile* profile) {
+  if (!local_state()->GetBoolean(prefs::kCloudPrintProxyEnabled)) {
+    std::string email;
+    if (profile->GetPrefs()->HasPrefPath(prefs::kCloudPrintEmail)) {
+      email = profile->GetPrefs()->GetString(prefs::kCloudPrintEmail);
+      if (!email.empty()) {
+        CloudPrintProxyServiceFactory::GetForProfile(profile)->
+            DisableForUser();
+        profile->GetPrefs()->SetString(prefs::kCloudPrintEmail, std::string());
+      }
+    }
+  }
+}
+
 // The BrowserProcess object must outlive the file thread so we use traits
 // which don't do any management.
 DISABLE_RUNNABLE_METHOD_REFCOUNT(BrowserProcessImpl);
 
 #if defined(IPC_MESSAGE_LOG_ENABLED)
 
 void BrowserProcessImpl::SetIPCLoggingEnabled(bool enable) {
   // First enable myself.
   if (enable)
     IPC::Logging::GetInstance()->Enable();
@@ skipping 79 matching lines @@
 }
 
 void BrowserProcessImpl::OnAutoupdateTimer() {
   if (CanAutorestartForUpdate()) {
     DLOG(WARNING) << "Detected update.  Restarting browser.";
     RestartBackgroundInstance();
   }
 }
 
 #endif  // (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS)