Parse the download server response.

Parse the SafeBrowsing download protection server response.

BUG=102540
TEST=run DownloadProtectionServiceTest::CheckClientDownloadSuccess.  Doesn't current have any visible side effects.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108315

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108413

[mattm, 2011-11-01 23:57:53]

lgtm with nits:
CL description: should mention that this is for SafeBrowsing download protection
TEST= line appears to be wrong
BUG -> should have one (I see we have a meta bug now.  The usual approach is to
have one or more bugs for implementation details which are marked as blocking
the meta bug)

http://codereview.chromium.org/8438012/diff/1/chrome/browser/safe_browsing/do...
File chrome/browser/safe_browsing/download_protection_service_unittest.cc
(right):

http://codereview.chromium.org/8438012/diff/1/chrome/browser/safe_browsing/do...
chrome/browser/safe_browsing/download_protection_service_unittest.cc:263: // If
the response is malicious the result should also be makred as malicious.
marked

[noelutz, 2011-11-02 00:55:31]

please take another look.

thanks,
noe.

http://codereview.chromium.org/8438012/diff/1/chrome/browser/safe_browsing/do...
File chrome/browser/safe_browsing/download_protection_service_unittest.cc
(right):

http://codereview.chromium.org/8438012/diff/1/chrome/browser/safe_browsing/do...
chrome/browser/safe_browsing/download_protection_service_unittest.cc:263: // If
the response is malicious the result should also be makred as malicious.
On 2011/11/01 23:57:53, mattm wrote:
> marked

Done.

[mattm, 2011-11-02 01:01:59]

bug should be 102540?
Test should be DownloadProtectionServiceTest?

[noelutz, 2011-11-02 01:18:31]

woops, sorry, fixed.
noe.

On Tue, Nov 1, 2011 at 6:01 PM,  <mattm@chromium.org> wrote:
> bug should be 102540?
> Test should be DownloadProtectionServiceTest?
>
> http://codereview.chromium.org/8438012/
>



-- 
-|||--

[mattm, 2011-11-02 01:22:01]

lgtm

[commit-bot: I haz the power, 2011-11-02 16:10:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noelutz@google.com/8438012/4002

[commit-bot: I haz the power, 2011-11-02 17:35:22]

Change committed as 108315

[noelutz, 2011-11-02 18:17:44]

On 2011/11/02 17:35:22, I haz the power (commit-bot) wrote:
> Change committed as 108315

Mhh. This broken the build and got reverted.  Investigating.

[noelutz, 2011-11-02 18:57:36]

On 2011/11/02 18:17:44, noelutz wrote:
> On 2011/11/02 17:35:22, I haz the power (commit-bot) wrote:
> > Change committed as 108315
> 
> Mhh. This broken the build and got reverted.  Investigating.

Tests pass fine locally.  Trying the try bots + clobber.

[commit-bot: I haz the power, 2011-11-03 00:09:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noelutz@google.com/8438012/3003

[commit-bot: I haz the power, 2011-11-03 03:29:13]

Change committed as 108413