Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: src/x64/codegen-x64.cc

Issue 8437092: Adding assertions to fast elements conversion. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Removing changes to runtime.cc Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 FieldOperand(r8, r9, times_8, FixedArray::kHeaderSize)); 247 FieldOperand(r8, r9, times_8, FixedArray::kHeaderSize));
248 // r9 : current element's index 248 // r9 : current element's index
249 // rbx: current element (smi-tagged) 249 // rbx: current element (smi-tagged)
250 __ JumpIfNotSmi(rbx, &convert_hole); 250 __ JumpIfNotSmi(rbx, &convert_hole);
251 __ SmiToInteger32(rbx, rbx); 251 __ SmiToInteger32(rbx, rbx);
252 __ cvtlsi2sd(xmm0, rbx); 252 __ cvtlsi2sd(xmm0, rbx);
253 __ movsd(FieldOperand(r14, r9, times_8, FixedDoubleArray::kHeaderSize), 253 __ movsd(FieldOperand(r14, r9, times_8, FixedDoubleArray::kHeaderSize),
254 xmm0); 254 xmm0);
255 __ jmp(&entry); 255 __ jmp(&entry);
256 __ bind(&convert_hole); 256 __ bind(&convert_hole);
257
258 if (FLAG_debug_code) {
259 Label is_really_the_hole;
260 __ CompareRoot(rbx, Heap::kTheHoleValueRootIndex);
261 __ j(equal, &is_really_the_hole);
262 __ Abort("object found in smi-only array");
263 __ bind(&is_really_the_hole);
264 }
265
257 __ movq(FieldOperand(r14, r9, times_8, FixedDoubleArray::kHeaderSize), r15); 266 __ movq(FieldOperand(r14, r9, times_8, FixedDoubleArray::kHeaderSize), r15);
258 __ bind(&entry); 267 __ bind(&entry);
259 __ decq(r9); 268 __ decq(r9);
260 __ j(not_sign, &loop); 269 __ j(not_sign, &loop);
261 } 270 }
262 271
263 272
264 void ElementsTransitionGenerator::GenerateDoubleToObject( 273 void ElementsTransitionGenerator::GenerateDoubleToObject(
265 MacroAssembler* masm, Label* fail) { 274 MacroAssembler* masm, Label* fail) {
266 // ----------- S t a t e ------------- 275 // ----------- S t a t e -------------
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 OMIT_SMI_CHECK); 368 OMIT_SMI_CHECK);
360 __ pop(rax); 369 __ pop(rax);
361 __ movq(rsi, Operand(rbp, StandardFrameConstants::kContextOffset)); 370 __ movq(rsi, Operand(rbp, StandardFrameConstants::kContextOffset));
362 } 371 }
363 372
364 #undef __ 373 #undef __
365 374
366 } } // namespace v8::internal 375 } } // namespace v8::internal
367 376
368 #endif // V8_TARGET_ARCH_X64 377 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698