Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: tests/standalone/src/EchoServerTest.dart

Issue 8437090: Change the handling of closing sockets (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Another fix to SocketCloseTest Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/src/EchoServerTest.dart
diff --git a/tests/standalone/src/EchoServerTest.dart b/tests/standalone/src/EchoServerTest.dart
index 23065628c207490bf2e3c872e231fd04a8ae0551..78f358d7fe8d9115fcd8277d5b5aefc422109b42 100644
--- a/tests/standalone/src/EchoServerTest.dart
+++ b/tests/standalone/src/EchoServerTest.dart
@@ -21,7 +21,7 @@ class EchoServerGame {
static final MSGSIZE = 10;
static final SERVERINIT = 0;
static final SERVERSHUTDOWN = -1;
- static final MESSAGES = 200;
+ static final MESSAGES = 100;
static final FIRSTCHAR = 65;
EchoServerGame.start()
@@ -73,13 +73,8 @@ class EchoServerGame {
handleRead();
}
- void closeHandler() {
- _socket.close();
- }
-
void errorHandler() {
- print("Socket error");
- _socket.close();
+ Expect.fail("Socket error");
}
void connectHandler() {
@@ -99,7 +94,6 @@ class EchoServerGame {
}
_socket.dataHandler = messageHandler;
- _socket.closeHandler = closeHandler;
_socket.errorHandler = errorHandler;
writeMessage();
}
@@ -108,7 +102,7 @@ class EchoServerGame {
if (_socket !== null) {
_socket.connectHandler = connectHandler;
} else {
- Expect.fail("socket creation failed");
+ Expect.fail("Socket creation failed");
}
}
@@ -174,6 +168,8 @@ class EchoServer extends Isolate {
bytesWritten += written;
if (bytesWritten < msgSize) {
_client.writeHandler = handleWrite;
+ } else {
+ _client.close(true);
}
}
handleWrite();
@@ -191,8 +187,7 @@ class EchoServer extends Isolate {
}
void errorHandler() {
- print("Socket error");
- _client.close();
+ Expect.fail("Socket error");
}
_client = _server.accept();
@@ -202,8 +197,7 @@ class EchoServer extends Isolate {
}
void errorHandlerServer() {
- print("Server socket error");
- _server.close();
+ Expect.fail("Server socket error");
}
this.port.receive((message, SendPort replyTo) {

Powered by Google App Engine
This is Rietveld 408576698