Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Unified Diff: tests/standalone/src/ProcessStdoutTest.dart

Issue 8437090: Change the handling of closing sockets (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments by ager@ Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/src/ProcessStderrTest.dart ('k') | tests/standalone/src/SocketCloseTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/src/ProcessStdoutTest.dart
diff --git a/tests/standalone/src/ProcessStdoutTest.dart b/tests/standalone/src/ProcessStdoutTest.dart
index 644ea4f0ba47fab8e2aee2e14ea56f842f28ca83..56abe30c9cc5bf8793e58b7e56b73144641ea851 100644
--- a/tests/standalone/src/ProcessStdoutTest.dart
+++ b/tests/standalone/src/ProcessStdoutTest.dart
@@ -35,17 +35,15 @@ class ProcessStdoutTest {
Expect.equals(data[received + i], buffer[i]);
}
received += buffer.length;
- if (received == BUFFERSIZE) {
- process.close();
- }
}
void streamClosed() {
Expect.equals(BUFFERSIZE, received);
+ process.close();
}
output.write(data);
- output.end();
+ output.close();
input.dataHandler = readData;
input.closeHandler = streamClosed;
}
@@ -56,5 +54,5 @@ class ProcessStdoutTest {
}
main() {
- ProcessStdoutTest.testMain();
+ ProcessStdoutTest.testStdout();
}
« no previous file with comments | « tests/standalone/src/ProcessStderrTest.dart ('k') | tests/standalone/src/SocketCloseTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698