Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/process_impl.dart

Issue 8437090: Change the handling of closing sockets (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments by ager@ Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/output_stream.dart ('k') | runtime/bin/socket.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process_impl.dart
diff --git a/runtime/bin/process_impl.dart b/runtime/bin/process_impl.dart
index fdea9d7162e870c6fdadb21aead8934310646a03..da02ccb578e0922743b2f3bf77c98b88861f9acf 100644
--- a/runtime/bin/process_impl.dart
+++ b/runtime/bin/process_impl.dart
@@ -29,9 +29,9 @@ class _Process implements Process {
_arguments[i] = arguments[i];
}
- _in = new _Socket._internal();
- _out = new _Socket._internal();
- _err = new _Socket._internal();
+ _in = new _Socket._internalOutputOnly();
+ _out = new _Socket._internalInputOnly();
+ _err = new _Socket._internalOutputOnly();
_exitHandler = new _Socket._internal();
_closed = false;
_killed = false;
« no previous file with comments | « runtime/bin/output_stream.dart ('k') | runtime/bin/socket.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698