Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 8437089: Add name= fields to sanity suppressions, suppress a couple of new[]/delete mismatches (Closed)

Created:
9 years, 1 month ago by Timur Iskhodzhanov
Modified:
9 years, 1 month ago
Reviewers:
Derek Bruening
CC:
chromium-reviews, Timur Iskhodzhanov, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Add name= fields to sanity suppressions, suppress a couple of new[]/delete mismatches Also fix the printed suppression count regexp so it works with leaks again BUG=101537, 101717 TBR=bruening Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108514

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -15 lines) Patch
M tools/valgrind/drmemory/suppressions.txt View 2 chunks +47 lines, -14 lines 2 comments Download
M tools/valgrind/drmemory_analyze.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Timur Iskhodzhanov
9 years, 1 month ago (2011-11-03 15:14:18 UTC) #1
Timur Iskhodzhanov
TBR http://codereview.chromium.org/8437089/diff/1/tools/valgrind/drmemory/suppressions.txt File tools/valgrind/drmemory/suppressions.txt (left): http://codereview.chromium.org/8437089/diff/1/tools/valgrind/drmemory/suppressions.txt#oldcode634 tools/valgrind/drmemory/suppressions.txt:634: UNINITIALIZED READ not removed - just moved downwards ...
9 years, 1 month ago (2011-11-03 15:15:26 UTC) #2
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 1 month ago (2011-11-03 15:15:37 UTC) #3
Alexander Potapenko
On 2011/11/03 15:15:37, I haz the power (commit-bot) wrote: > No LGTM from valid reviewers ...
9 years, 1 month ago (2011-11-03 15:18:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timurrrr@chromium.org/8437089/1
9 years, 1 month ago (2011-11-03 15:18:44 UTC) #5
commit-bot: I haz the power
Try job failure for 8437089-1 (retry) on linux_rel for step "compile" (clobber build). It's a ...
9 years, 1 month ago (2011-11-03 15:46:02 UTC) #6
Derek Bruening
9 years, 1 month ago (2011-11-03 17:30:31 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld 408576698