Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 8437088: Copy libWebKitSystemInterfaceLeopard.a into third_party/apple/. (Closed)

Created:
9 years, 1 month ago by Robert Sesek
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Copy libWebKitSystemInterfaceLeopard.a into third_party/apple_webkit/. This also moves third_party/apple to third_party/apple_sample_code/. BUG=101387 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108475

Patch Set 1 #

Patch Set 2 : Move it around #

Unified diffs Side-by-side diffs Delta from patch set Stats (+504 lines, -276 lines) Patch
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/apple/ImageAndTextCell.h View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/apple/ImageAndTextCell.m View 1 chunk +0 lines, -171 lines 0 comments Download
D third_party/apple/LICENSE View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/apple/README.chromium View 1 chunk +0 lines, -7 lines 0 comments Download
A + third_party/apple_sample_code/ImageAndTextCell.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/apple_sample_code/ImageAndTextCell.m View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/apple_sample_code/LICENSE View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/apple_sample_code/README.chromium View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/apple_webkit/LICENSE View 1 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/apple_webkit/README.chromium View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/apple_webkit/WebKitSystemInterface.h View 1 1 chunk +478 lines, -0 lines 0 comments Download
A third_party/apple_webkit/libWebKitSystemInterfaceLeopard.a View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Robert Sesek
9 years, 1 month ago (2011-11-03 14:45:23 UTC) #1
Mark Mentovai
Mention changes in README.chromium.
9 years, 1 month ago (2011-11-03 14:47:55 UTC) #2
Mark Mentovai
LGTM with that.
9 years, 1 month ago (2011-11-03 14:49:21 UTC) #3
Avi (use Gerrit)
Two questions: First, if you're making subdirectories in apple/, what about apple_apsl? Two, how do ...
9 years, 1 month ago (2011-11-03 14:49:59 UTC) #4
Robert Sesek
OK. Changed apple/{sample_code,webkit} to apple_{sample_code,webkit}/. And listed modifications to README.chromium.
9 years, 1 month ago (2011-11-03 15:51:33 UTC) #5
Mark Mentovai
LGTM
9 years, 1 month ago (2011-11-03 16:02:00 UTC) #6
Avi (use Gerrit)
9 years, 1 month ago (2011-11-03 18:43:57 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld 408576698