Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: chrome/browser/extensions/extension_tts_api_controller.h

Issue 8437080: Fix crash when TTS utterances are queued on shutdown. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tts_api_controller.h
===================================================================
--- chrome/browser/extensions/extension_tts_api_controller.h (revision 107928)
+++ chrome/browser/extensions/extension_tts_api_controller.h (working copy)
@@ -220,10 +220,11 @@
void SetPlatformImpl(ExtensionTtsPlatformImpl* platform_impl);
int QueueSize();
- private:
+ protected:
ExtensionTtsController();
virtual ~ExtensionTtsController();
+ private:
// Get the platform TTS implementation (or injected mock).
ExtensionTtsPlatformImpl* GetPlatformImpl();
@@ -231,8 +232,9 @@
// |utterance| or delete it if there's an error. Returns true on success.
void SpeakNow(Utterance* utterance);
- // Clear the utterance queue.
- void ClearUtteranceQueue();
+ // Clear the utterance queue. If send_events is true, will send
+ // TTS_EVENT_CANCELLED events on each one.
+ void ClearUtteranceQueue(bool send_events);
// Finalize and delete the current utterance.
void FinishCurrentUtterance();

Powered by Google App Engine
This is Rietveld 408576698