Fix crash when TTS utterances are queued on shutdown.

Fix crash when TTS utterances are queued on shutdown.

BUG=99126
TEST=Adds new unit test.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110312

[dmazzoni, 2011-11-08 05:50:29]

Ping

[Aaron Boodman, 2011-11-16 09:23:47]

You should move this out of chrome/browser/extensions so that someone on
extensions team doesn't have to review it everytime.

See crbug.com/101244 for more details and examples.

[Aaron Boodman, 2011-11-16 09:26:36]

lgtm

http://codereview.chromium.org/8437080/diff/8/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_tts_api_controller.cc (right):

http://codereview.chromium.org/8437080/diff/8/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_tts_api_controller.cc:156:
ClearUtteranceQueue(/*send_events=*/false);
It's more common in Chrome code to do:

ClearUtteranceQueue(false);  // don't send events

Or you can define a named constant, like:

const bool kSendEvents = false;
Clear(kSendEvents);

[dmazzoni, 2011-11-16 15:50:39]

Thanks. I filed http://crbug.com/104467 to move the TTS extension API out of
chrome/browser/extensions.

http://codereview.chromium.org/8437080/diff/8/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_tts_api_controller.cc (right):

http://codereview.chromium.org/8437080/diff/8/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_tts_api_controller.cc:156:
ClearUtteranceQueue(/*send_events=*/false);
On 2011/11/16 09:26:36, Aaron Boodman wrote:
> It's more common in Chrome code to do:
> 
> ClearUtteranceQueue(false);  // don't send events
> 
> Or you can define a named constant, like:
> 
> const bool kSendEvents = false;
> Clear(kSendEvents);

Done.

[commit-bot: I haz the power, 2011-11-16 15:50:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/8437080/10001

[commit-bot: I haz the power, 2011-11-16 16:55:17]

Change committed as 110312