- Add the implementation of the Options interface to the runtime.

- Add the implementation of the Options interface to the runtime.
Committed: https://code.google.com/p/dart/source/detail?r=1169

[Ivan Posva, 2011-11-03 00:32:20]

I will be adding runtime test cases once we agree that this is the correct
approach.

-Ivan

[dgrove, 2011-11-03 04:09:10]

lgtm

I'm happy with the .dart side of this. 

I suspect that someday, we may want to add something like

List<String> get nativeArguments()

which would provide an unadulterated copy of the original args.

I don't see the reason for this yet, though, so I think we should leave this out
until it becomes obvious.

[kasperl, 2011-11-03 06:17:11]

LGTM.

http://codereview.chromium.org/8437075/diff/1/lib/options.dart
File lib/options.dart (right):

http://codereview.chromium.org/8437075/diff/1/lib/options.dart#newcode17
lib/options.dart:17: static List<String> _native_arguments = const [];
Use proper camelCase: _nativeArguments.

[siva, 2011-11-03 18:46:32]

LGTM.

The spawned isolates are not going to see these RuntimeOptions as we are not
setting them when spawning an isolate. Not sure what the specifications are for
this case.

[Ivan Posva, 2011-11-03 21:13:11]

On 2011/11/03 04:09:10, dgrove wrote:
> lgtm
> 
> I'm happy with the .dart side of this. 
> 
> I suspect that someday, we may want to add something like
> 
> List<String> get nativeArguments()
> 
> which would provide an unadulterated copy of the original args.
> 
> I don't see the reason for this yet, though, so I think we should leave this
out
> until it becomes obvious.

If you want an unadulterated copy of the original arguments you can do the
following: unadulteradedArgs = (new Options()).arguments;

If you want to modify the arguments, then you modify the list and pass around
the modified list or the Options object containing this list.

-Ivan

[Ivan Posva, 2011-11-03 21:14:49]

On 2011/11/03 18:46:32, asiva wrote:
> LGTM.
> 
> The spawned isolates are not going to see these RuntimeOptions as we are not
> setting them when spawning an isolate. Not sure what the specifications are
for
> this case.

Not passing them on to spawned isolates is as planned. Kasper and I discussed
passing an optional Options object when spawning an isolate. For that we would
need a different implementation of Options, which allows you to setup the
values.

-Ivan

[Ivan Posva, 2011-11-03 21:43:28]

Thanks! Submitting...

-Ivan

http://codereview.chromium.org/8437075/diff/1/lib/options.dart
File lib/options.dart (right):

http://codereview.chromium.org/8437075/diff/1/lib/options.dart#newcode17
lib/options.dart:17: static List<String> _native_arguments = const [];
On 2011/11/03 06:17:11, kasperl wrote:
> Use proper camelCase: _nativeArguments.

Done.