Linux: Periodically check for changes to the icon directories and refresh icons for mime types pe...

Linux: Periodically check for changes to the icon directories and refresh icons for mime types per XDG icon theme spec.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109607

[Lei Zhang, 2011-11-02 02:02:09]

This CL, and then I move it into base/nix, since no other platform uses
base/mime_util.h.

http://codereview.chromium.org/8437039/diff/1/base/mime_util_xdg.cc
File base/mime_util_xdg.cc (left):

http://codereview.chromium.org/8437039/diff/1/base/mime_util_xdg.cc#oldcode457
base/mime_util_xdg.cc:457: // Gadgets for Linux.
Google Gadgets for Linux is kinda dead at this point.

http://codereview.chromium.org/8437039/diff/1/base/mime_util_xdg.cc
File base/mime_util_xdg.cc (right):

http://codereview.chromium.org/8437039/diff/1/base/mime_util_xdg.cc#newcode482
base/mime_util_xdg.cc:482: constants->icon_themes_.clear();
Turns out I should clear this too, but it was not clear until I actually
implemented the refresh code.

[willchan no longer on Chromium, 2011-11-07 21:37:06]

lgtm

http://codereview.chromium.org/8437039/diff/1/base/mime_util_xdg.cc
File base/mime_util_xdg.cc (right):

http://codereview.chromium.org/8437039/diff/1/base/mime_util_xdg.cc#newcode42
base/mime_util_xdg.cc:42: typedef std::map<FilePath, base::Time>
IconDirMtimeMap;
Are you sure you don't want TimeTicks instead? The difference is base::Time may
jump due to timezone / daylight savings changes.

[Lei Zhang, 2011-11-11 00:30:11]

http://codereview.chromium.org/8437039/diff/1/base/mime_util_xdg.cc
File base/mime_util_xdg.cc (right):

http://codereview.chromium.org/8437039/diff/1/base/mime_util_xdg.cc#newcode42
base/mime_util_xdg.cc:42: typedef std::map<FilePath, base::Time>
IconDirMtimeMap;
On 2011/11/07 21:37:06, willchan wrote:
> Are you sure you don't want TimeTicks instead? The difference is base::Time
may
> jump due to timezone / daylight savings changes.

The time comes from a stat() call. It's always relative to Unix epoch.

I did change |last_check_time_| below to TimeTicks.

[commit-bot: I haz the power, 2011-11-11 08:56:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/8437039/5001

[commit-bot: I haz the power, 2011-11-11 08:56:42]

Can't apply patch for file base/mime_util_xdg.cc.
While running patch -p0 --forward --force;
patching file base/mime_util_xdg.cc
Hunk #1 FAILED at 5.
Hunk #2 succeeded at 25 with fuzz 2 (offset -1 lines).
Hunk #3 succeeded at 44 (offset 3 lines).
Hunk #4 succeeded at 68 with fuzz 2 (offset 3 lines).
Hunk #5 succeeded at 78 with fuzz 1 (offset 5 lines).
Hunk #6 succeeded at 396 (offset 5 lines).
Hunk #7 succeeded at 425 (offset 5 lines).
Hunk #8 succeeded at 457 (offset 5 lines).
1 out of 8 hunks FAILED -- saving rejects to file base/mime_util_xdg.cc.rej

[commit-bot: I haz the power, 2011-11-11 09:20:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/8437039/11001

[commit-bot: I haz the power, 2011-11-11 10:14:34]

Change committed as 109607