Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp - Issue 8437036: Merge 98796 - Potential crash in ReplaceNodeWithSpanCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp

Issue 8437036: Merge 98796 - Potential crash in ReplaceNodeWithSpanCommand (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/912/

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp

===================================================================

--- Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp (revision 99022)

+++ Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp (working copy)

@@ -52,7 +52,7 @@

{

ASSERT(nodeToReplace->inDocument());

ExceptionCode ec = 0;

- ContainerNode* parentNode = nodeToReplace->parentNode();

+ RefPtr<ContainerNode> parentNode = nodeToReplace->parentNode();

parentNode->insertBefore(newNode, nodeToReplace, ec);

ASSERT(!ec);

« no previous file with comments | « no previous file | no next file » | no next file with comments »