Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp

Issue 8437036: Merge 98796 - Potential crash in ReplaceNodeWithSpanCommand (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/912/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp
===================================================================
--- Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp (revision 99022)
+++ Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp (working copy)
@@ -52,7 +52,7 @@
{
ASSERT(nodeToReplace->inDocument());
ExceptionCode ec = 0;
- ContainerNode* parentNode = nodeToReplace->parentNode();
+ RefPtr<ContainerNode> parentNode = nodeToReplace->parentNode();
parentNode->insertBefore(newNode, nodeToReplace, ec);
ASSERT(!ec);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698