|
|
Revert 108207 - HQP Refactoring (in Preparation for SQLite Cache)
1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs.
2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available.
3. Correctly handle the adding and removing of page title words when a URL change is detected.
4. Other small cleanups.
BUG= 96731, 92718
TEST=Unit tests updated.
TBR=atwilson (for profile_sync_service_typed_url_unittest.cc)
Review URL: http://codereview.chromium.org/8384024
TBR=mrossetti@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108224
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+163 lines, -229 lines) |
Patch |
 |
M |
chrome/browser/autocomplete/history_provider.h
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/autocomplete/history_provider.cc
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/autocomplete/history_quick_provider_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/expire_history_backend.cc
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/history.cc
|
View
|
|
3 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/history_backend.h
|
View
|
|
4 chunks |
+1 line, -13 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/history_backend.cc
|
View
|
|
5 chunks |
+2 lines, -17 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/history_backend_unittest.cc
|
View
|
|
4 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/history_notifications.h
|
View
|
|
5 chunks |
+5 lines, -10 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/history_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/in_memory_history_backend.h
|
View
|
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/in_memory_history_backend.cc
|
View
|
|
3 chunks |
+30 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/in_memory_url_index.h
|
View
|
|
6 chunks |
+9 lines, -23 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/in_memory_url_index.cc
|
View
|
|
4 chunks |
+35 lines, -72 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/in_memory_url_index_unittest.cc
|
View
|
|
16 chunks |
+62 lines, -60 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
8437035:
Revert 108207 - HQP Refactoring (in Preparation for SQLite Cache) (Closed)
