Android IPC changes.

Android IPC changes.


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108589

[John Grabowski, 2011-11-02 01:40:19]

+cc Michael

[dmac, 2011-11-02 20:29:58]

LGTM

http://codereview.chromium.org/8437033/diff/3001/ipc/ipc_channel_posix_unitte...
File ipc/ipc_channel_posix_unittest.cc (right):

http://codereview.chromium.org/8437033/diff/3001/ipc/ipc_channel_posix_unitte...
ipc/ipc_channel_posix_unittest.cc:185: static const char* kChannelName =
no need for static here is there?

Also above you put the decl in the #if block.. could we choose one form or
another for consistency?

[John Grabowski, 2011-11-03 18:27:04]

On 2011/11/02 20:29:58, dmac wrote:
> LGTM
> 
>
http://codereview.chromium.org/8437033/diff/3001/ipc/ipc_channel_posix_unitte...
> File ipc/ipc_channel_posix_unittest.cc (right):
> 
>
http://codereview.chromium.org/8437033/diff/3001/ipc/ipc_channel_posix_unitte...
> ipc/ipc_channel_posix_unittest.cc:185: static const char* kChannelName =
> no need for static here is there?
> 
> Also above you put the decl in the #if block.. could we choose one form or
> another for consistency?

Thx for review.  Feedback applied.  Will hit try server once more before
landing.

[commit-bot: I haz the power, 2011-11-03 20:32:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jrg@chromium.org/8437033/7001

[commit-bot: I haz the power, 2011-11-03 22:09:53]

Try job failure for 8437033-7001 (retry) on win_rel for step
"chrome_frame_net_tests".
It's a second try, previously, step "chrome_frame_net_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-11-03 23:00:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jrg@chromium.org/8437033/7001

[commit-bot: I haz the power, 2011-11-04 00:14:21]

Change committed as 108589