Bitcode parsing modifications for streaming

DEPRECATED: these changes have been rolled into
http://codereview.chromium.org/8393017/
(this CL still just shows the parsing-related changes however.)

Bitcode parsing modifications to enable streaming
      Write metadata and value symtable before function bodies in bitcode
      Make Module parsing suspendable/resumable (if using streaming, suspend after each function body and resume on Materialize)

still has some debug printfs and a couple of TODOs, but the basic idea is here and works.

[(google.com) Derek Schuff, 2011-11-02 00:01:47]

Prototype modifications for streaming now pass SPEC. documentation forthcoming
in the design doc

[(google.com) Derek Schuff, 2011-11-02 00:08:30]

Fix email addresses
On 2011/11/02 00:01:47, Derek Schuff wrote:
> Prototype modifications for streaming now pass SPEC. documentation forthcoming
> in the design doc

[jasonwkim, 2011-11-03 17:53:38]

On 2011/11/02 00:08:30, Derek Schuff wrote:
> Fix email addresses
> On 2011/11/02 00:01:47, Derek Schuff wrote:
> > Prototype modifications for streaming now pass SPEC. documentation
forthcoming
> > in the design doc


just one doc nit - otherwise LGTM

[jasonwkim, 2011-11-03 17:54:08]

http://codereview.chromium.org/8437024/diff/1/lib/Bitcode/Reader/BitcodeReade...
File lib/Bitcode/Reader/BitcodeReader.cpp (right):

http://codereview.chromium.org/8437024/diff/1/lib/Bitcode/Reader/BitcodeReade...
lib/Bitcode/Reader/BitcodeReader.cpp:1564: // TODO(dschuff) this probably only
needs to be done once (currently it's a
I think upstream guys dont like TODO(username) - 
you might want to change it if you are planning to upstream (you should :-)

http://codereview.chromium.org/8437024/diff/1/lib/Bitcode/Writer/BitcodeWrite...
File lib/Bitcode/Writer/BitcodeWriter.cpp (right):

http://codereview.chromium.org/8437024/diff/1/lib/Bitcode/Writer/BitcodeWrite...
lib/Bitcode/Writer/BitcodeWriter.cpp:1616: // Emit function bodies.
can you explain why you needed to move this block?

[(google.com) Derek Schuff, 2011-11-03 18:01:26]

This is not a final CL BTW. the TODOs will go away, at the very least.

http://codereview.chromium.org/8437024/diff/1/lib/Bitcode/Reader/BitcodeReade...
File lib/Bitcode/Reader/BitcodeReader.cpp (right):

http://codereview.chromium.org/8437024/diff/1/lib/Bitcode/Reader/BitcodeReade...
lib/Bitcode/Reader/BitcodeReader.cpp:1564: // TODO(dschuff) this probably only
needs to be done once (currently it's a
These will go away before I upstream it.

On 2011/11/03 17:54:09, jasonwkim wrote:
> I think upstream guys dont like TODO(username) - 
> you might want to change it if you are planning to upstream (you should :-)

http://codereview.chromium.org/8437024/diff/1/lib/Bitcode/Writer/BitcodeWrite...
File lib/Bitcode/Writer/BitcodeWriter.cpp (right):

http://codereview.chromium.org/8437024/diff/1/lib/Bitcode/Writer/BitcodeWrite...
lib/Bitcode/Writer/BitcodeWriter.cpp:1616: // Emit function bodies.
It is explained in the design document, in the "bitcode parsing" section under
proposed changes

On 2011/11/03 17:54:09, jasonwkim wrote:
> can you explain why you needed to move this block?