Issue 8437018: Test 32bit time in tracked_object

Issue 8437018: Test 32bit time in tracked_object (Closed)

Created:
9 years, 1 month ago by jar (doing other things)

Modified:
9 years, 1 month ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Test 32bit time in tracked_object Be sure it is disabled or enabled as expected. Be sure it is using the same basic function as TimeTicks. r=rtenneti Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108228

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 8

Patch Set 4 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -0 lines)			Patch
	M	base/tracked_objects_unittest.cc	View	1 2 3	1 chunk	+98 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

lgtm http://codereview.chromium.org/8437018/diff/4001/base/tracked_objects_unittest.cc File base/tracked_objects_unittest.cc (right): http://codereview.chromium.org/8437018/diff/4001/base/tracked_objects_unittest.cc#newcode656 base/tracked_objects_unittest.cc:656: // Then get a 32 bit timer that ...

9 years, 1 month ago (2011-11-02 01:17:12 UTC) #2

jar (doing other things)

9 years, 1 month ago (2011-11-02 01:34:49 UTC) #3

Changes made per comments by rtenneti.

http://codereview.chromium.org/8437018/diff/4001/base/tracked_objects_unittes...
File base/tracked_objects_unittest.cc (right):

http://codereview.chromium.org/8437018/diff/4001/base/tracked_objects_unittes...
base/tracked_objects_unittest.cc:656: // Then get a 32 bit timer that can be be
null when it wraps.
On 2011/11/02 01:17:12, ramant wrote:
> nit: be be -> be

Done.

http://codereview.chromium.org/8437018/diff/4001/base/tracked_objects_unittes...
base/tracked_objects_unittest.cc:663: // No make sure that we bracketed our
tracked time nicely.
On 2011/11/02 01:17:12, ramant wrote:
> nit: No -> Now

Done.

http://codereview.chromium.org/8437018/diff/4001/base/tracked_objects_unittes...
base/tracked_objects_unittest.cc:689: // Then get a 32 bit timer that can be be
null when it wraps.
On 2011/11/02 01:17:12, ramant wrote:
> nit: TrackedTimerVsTicks -> TrackedTime Vs TimeTicks

Done.

http://codereview.chromium.org/8437018/diff/4001/base/tracked_objects_unittes...
base/tracked_objects_unittest.cc:697: // No make sure that we bracketed our
tracked time nicely.
On 2011/11/02 01:17:12, ramant wrote:
> nit: No -> Now

Done.

Expand Messages | Collapse Messages