Fix subtle flakiness from ZipTest.

Fix subtle flakiness from ZipTest.

UnzipEvil and UnzipEvil2 check that we don't extract files containing ..
in their file names. These tests failed if we had
"levilevilevilevilevilevilevilevilevilevilevilevil" and "evil.txt" in /tmp
on Linux, as we were checking the existence of these files from a temporary
directory like /tmp/.org.chromium.Chromium.aXW1Gx.

We should create a directory one level deeper to fix the subtle issue.

TEST=touch /tmp/levilevilevilevilevilevilevilevilevilevilevilevil /tmp/evil.txt; out/Release/unit_tests --gtest_filter=ZipTest.*
BUG=chromium-os:22351
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108195

[Aaron Boodman, 2011-11-01 22:16:57]

lgtm, thanks!

[commit-bot: I haz the power, 2011-11-01 22:23:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satorux@chromium.org/8437016/1

[commit-bot: I haz the power, 2011-11-01 23:28:32]

Change committed as 108195

[Paweł Hajdan Jr., 2011-11-02 09:43:50]

I think if you could use ScopedTempDir the test would be even more solid. I
think that now there is still some potential for leaving some temporary files
around and interfering with each other.

[satorux1, 2011-11-02 14:27:48]

On 2011/11/02 09:43:50, Paweł Hajdan Jr. wrote:
> I think if you could use ScopedTempDir the test would be even more solid. I
> think that now there is still some potential for leaving some temporary files
> around and interfering with each other.

The test already uses ScopedTempDir, and temp directories like
/tmp/.org.chromium.Chromium.aXW1Gx are created in SetUp() using ScopedTempDir.

[Paweł Hajdan Jr., 2011-11-02 18:02:35]

On 2011/11/02 14:27:48, satorux1 wrote:
> The test already uses ScopedTempDir, and temp directories like
> /tmp/.org.chromium.Chromium.aXW1Gx are created in SetUp() using ScopedTempDir.

Ah right, looks like my pattern matching was too eager, and I didn't read the
code carefully enough. Makes sense, and sorry for inaccurate comment.

[satorux1, 2011-11-02 23:19:01]

On 2011/11/02 18:02:35, Paweł Hajdan Jr. wrote:
> On 2011/11/02 14:27:48, satorux1 wrote:
> > The test already uses ScopedTempDir, and temp directories like
> > /tmp/.org.chromium.Chromium.aXW1Gx are created in SetUp() using
ScopedTempDir.
> 
> Ah right, looks like my pattern matching was too eager, and I didn't read the
> code carefully enough. Makes sense, and sorry for inaccurate comment.

Never mind. Your drive-by comments are often very useful. Keep sending these my
way. :)