Add unit test for the repeating button.

Add unit test for the repeating button.

BUG=chromium:100732
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108328

[kevers, 2011-11-01 17:10:34]

Hi James,

Can you please have a look at this CL, which adds a unit test for the repeating
button.  This button is currently being used for brightness controls in
ChromeOS.

Thanks,

Kevin

[arv1, 2011-11-01 17:49:37]

LGTM

http://codereview.chromium.org/8437004/diff/2001/chrome/browser/resources/sha...
File chrome/browser/resources/shared/js/cr/ui/repeating_button.js (right):

http://codereview.chromium.org/8437004/diff/2001/chrome/browser/resources/sha...
chrome/browser/resources/shared/js/cr/ui/repeating_button.js:149: * @return
{number} The delay in milliseconds.
Use @type for getters/setters

[James Hawkins, 2011-11-02 05:39:11]

http://codereview.chromium.org/8437004/diff/5003/chrome/browser/resources/sha...
File chrome/browser/resources/shared/js/cr/ui/repeating_button_test.html
(right):

http://codereview.chromium.org/8437004/diff/5003/chrome/browser/resources/sha...
chrome/browser/resources/shared/js/cr/ui/repeating_button_test.html:5: <script
src="http://closure-library.googlecode.com/svn/trunk/closure/goog/base.js"></script>
nit: 80 cols.

http://codereview.chromium.org/8437004/diff/5003/chrome/browser/resources/sha...
chrome/browser/resources/shared/js/cr/ui/repeating_button_test.html:5: <script
src="http://closure-library.googlecode.com/svn/trunk/closure/goog/base.js"></script>
Does this work if the test machine is offline?

[kevers, 2011-11-02 15:38:34]

http://codereview.chromium.org/8437004/diff/5003/chrome/browser/resources/sha...
File chrome/browser/resources/shared/js/cr/ui/repeating_button_test.html
(right):

http://codereview.chromium.org/8437004/diff/5003/chrome/browser/resources/sha...
chrome/browser/resources/shared/js/cr/ui/repeating_button_test.html:5: <script
src="http://closure-library.googlecode.com/svn/trunk/closure/goog/base.js"></script>
On 2011/11/02 05:39:12, James Hawkins wrote:
> nit: 80 cols.

Pushed closing tag to the next line, but address is too long to fit in 80
columns without breaking other formatting rules.

http://codereview.chromium.org/8437004/diff/5003/chrome/browser/resources/sha...
chrome/browser/resources/shared/js/cr/ui/repeating_button_test.html:5: <script
src="http://closure-library.googlecode.com/svn/trunk/closure/goog/base.js"></script>
On 2011/11/02 05:39:12, James Hawkins wrote:
> Does this work if the test machine is offline?

Appears that the test machine needs to be online.  At this point the test is not
part of the automated framework, but follows the pattern used by other unit
tests for shared components.

[commit-bot: I haz the power, 2011-11-02 15:39:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/8437004/3006

[scr, 2011-11-02 16:15:33]

Would love to see this use the automated unit_test but need to land
1-2 patches to support this - 1 for the framework, 1 to allow include
of other js files. Both are working and pending review.

As this test is not automated and won't be run if committed, can it
wait for automation?

-SCR

Sent from my iPhone

On Nov 2, 2011, at 8:38 AM, "kevers@chromium.org" <kevers@chromium.org> wrote:

>
>
http://codereview.chromium.org/8437004/diff/5003/chrome/browser/resources/sha...
> File chrome/browser/resources/shared/js/cr/ui/repeating_button_test.html
> (right):
>
>
http://codereview.chromium.org/8437004/diff/5003/chrome/browser/resources/sha...
> chrome/browser/resources/shared/js/cr/ui/repeating_button_test.html:5:
> <script
>
src="http://closure-library.googlecode.com/svn/trunk/closure/goog/base.js"></script>
> On 2011/11/02 05:39:12, James Hawkins wrote:
>> nit: 80 cols.
>
> Pushed closing tag to the next line, but address is too long to fit in
> 80 columns without breaking other formatting rules.
>
>
http://codereview.chromium.org/8437004/diff/5003/chrome/browser/resources/sha...
> chrome/browser/resources/shared/js/cr/ui/repeating_button_test.html:5:
> <script
>
src="http://closure-library.googlecode.com/svn/trunk/closure/goog/base.js"></script>
> On 2011/11/02 05:39:12, James Hawkins wrote:
>> Does this work if the test machine is offline?
>
> Appears that the test machine needs to be online.  At this point the
> test is not part of the automated framework, but follows the pattern
> used by other unit tests for shared components.
>
> http://codereview.chromium.org/8437004/

[kevers, 2011-11-02 16:41:44]

It can wait.

[commit-bot: I haz the power, 2011-11-02 18:06:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/8437004/3006

[commit-bot: I haz the power, 2011-11-02 19:15:47]

Change committed as 108328