content/ppapi_plugin/ppapi_thread.cc - Issue 8436008: Add check on invalid file descriptor at both broker and renderer sides.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/ppapi_plugin/ppapi_thread.cc

Issue 8436008: Add check on invalid file descriptor at both broker and renderer sides. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Made the test fixture much simpler. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/ppapi_plugin/ppapi_thread.cc

diff --git a/content/ppapi_plugin/ppapi_thread.cc b/content/ppapi_plugin/ppapi_thread.cc

index 1bb38b1113a8498a4e4b70b9ae2efb4500a33324..b437de2390b80382232ce75e9860994ed4949a34 100644

--- a/content/ppapi_plugin/ppapi_thread.cc

+++ b/content/ppapi_plugin/ppapi_thread.cc

@@ -300,6 +300,8 @@ bool PpapiThread::SetupRendererChannel(base::ProcessHandle host_process_handle,

// On POSIX, pass the renderer-side FD.

handle->socket = base::FileDescriptor(::dup(dispatcher->GetRendererFD()),

true);

+ if (handle->socket.fd == -1)

+ return false;

#endif

// From here, the dispatcher will manage its own lifetime according to the

« no previous file with comments | « content/content_tests.gypi ('k') | content/renderer/pepper_plugin_delegate_impl.cc » ('j') | content/renderer/pepper_plugin_delegate_impl.cc » ('J')