Fix X509CertificateTest.SerialNumbers on OpenSSL builds after http://crrev.com/107956

Fix X509CertificateTest.SerialNumbers on OpenSSL builds after http://crrev.com/107956

BUG=none
TEST=X509CertificateTest.SerialNumbers no longer failing on http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20Redux

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108088

[Ryan Sleevi, 2011-11-01 05:14:24]

PTAL. Most notably, ASN1_INTEGER's value is in a format internal to OpenSSL - it
expresses the information about sign via ->type, rather than by the lead byte.
This ensures that regardless of OpenSSL's behaviour, serial numbers will always
reflect the DER value.

Unfortunately, this DER value may /not/ reflect the value as encoded in the
certificate. AFAICT, OpenSSL doesn't provide a way to get the raw (unmolested)
DER - even the processing to an ASN1_INTEGER may lose that information - short
of writing custom ASN.1 templates.

[joth, 2011-11-01 09:16:33]

LGTM, thanks!

agl: I believe this patch replaces http://codereview.chromium.org/8387032/ so no
need to land that (it will conflict anyway. but thanks again for doing it)

http://codereview.chromium.org/8432026/diff/2002/net/base/x509_certificate_op...
File net/base/x509_certificate_openssl.cc (right):

http://codereview.chromium.org/8432026/diff/2002/net/base/x509_certificate_op...
net/base/x509_certificate_openssl.cc:338: // value.
I think the comment already answers this, but is the re-encoded DER be
guaranteed to include that leading zero?

[commit-bot: I haz the power, 2011-11-01 09:55:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8432026/2002

[commit-bot: I haz the power, 2011-11-01 09:55:41]

Presubmit check for 8432026-2002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for: net/base/x509_certificate_openssl.cc

[joth, 2011-11-01 09:57:14]

On 2011/11/01 09:16:33, joth wrote:
> LGTM, thanks!
> 

Hope it's OK but I went ahead and sent this to the CQ, to appease the angry pig
sat over my desk (aka buildbot status monitor) :)

[commit-bot: I haz the power, 2011-11-01 09:59:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8432026/2002

[commit-bot: I haz the power, 2011-11-01 09:59:53]

Presubmit check for 8432026-2002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: net/base/x509_certificate_openssl.cc

Presubmit checks took 1.6s to calculate.

[joth, 2011-11-01 10:16:53]

On 2011/11/01 09:59:53, I haz the power (commit-bot) wrote:

Forgot the commit bot wouldn't like it, so I went ahead and landed it manually
to get the builder green again.

Cheers!