Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: net/http/http_pipelined_stream.cc

Issue 8432024: Correctly create a new stream when the server requires authentication. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_pipelined_stream.cc
diff --git a/net/http/http_pipelined_stream.cc b/net/http/http_pipelined_stream.cc
index 2183c528fcfbd749c99683af6cc4b20e73ac1b7f..f4b8401d187f3705b268d966e09d94670e1738eb 100644
--- a/net/http/http_pipelined_stream.cc
+++ b/net/http/http_pipelined_stream.cc
@@ -71,8 +71,11 @@ void HttpPipelinedStream::Close(bool not_reusable) {
}
HttpStream* HttpPipelinedStream::RenewStreamForAuth() {
- // FIXME: What does this mean on a pipeline? Is it for proxies?
- return new HttpPipelinedStream(pipeline_, pipeline_id_);
+ if (pipeline_->usable()) {
+ return pipeline_->CreateNewStream();
+ } else {
mmenke 2011/11/01 14:21:55 nit: It's chrome style not to use else statements
+ return NULL;
+ }
}
bool HttpPipelinedStream::IsResponseBodyComplete() const {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698