Issue 8432020: aura: Work around RenderWidgetHostTest.Background segfault.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8432020: aura: Work around RenderWidgetHostTest.Background segfault. (Closed)

Created:
9 years, 1 month ago by Daniel Erat

Modified:
9 years, 1 month ago

Reviewers:
Ben Goodger (Google), sky

CC:
chromium-reviews, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

aura: Work around RenderWidgetHostTest.Background segfault. This test was creating an aura::Window but not calling its Init() method, resulting in a segfault when RenderWidgetHostViewAura::SetBackground() tried to access the window's layer. I have a more ambitious change in progress to add a RenderWidgetHostView::InitAsChild() method and update a bunch of callers; this is just a quick workaround so try bots will stop failing. BUG=102450 TEST=manual: test no longer segfaults Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108048

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -6 lines)			Patch
M	chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_unittest.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages