Issue 8432015: Fix compile error on XCode4 / clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8432015: Fix compile error on XCode4 / clang. (Closed)

Created:
9 years, 1 month ago by dhollowa

Modified:
9 years, 1 month ago

Reviewers:
Nico, (unused - use chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix compile error on XCode4 / clang. Fixes XCode4.2 compilation error: method attribute can only be specified on method declarations [-Werror,2] This is a result of XCode4.2 adding "-DIBAction=void)__attribute__((ibaction)" magic. BUG=102429 TEST=compile under XCode4.2 R=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108041

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhollowa@chromium.org/8432015/1

9 years, 1 month ago (2011-10-31 22:43:12 UTC) #3

Change committed as 108041

Expand Messages | Collapse Messages