Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 8432010: MIPS: Merge IR classes for different bitwise operations AND, OR and XOR into one class. (Closed)

Created:
9 years, 1 month ago by kisg
Modified:
9 years, 1 month ago
Reviewers:
Paul Lind, fschneider, danno
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@bleeding_edge
Visibility:
Public.

Description

MIPS: Merge IR classes for different bitwise operations AND, OR and XOR into one class. Port r9846 (4cd055a). Original commit message: Since we already have only one LIR class, it does not make much sense to separate them at the HIR level. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -40 lines) Patch
M src/mips/lithium-mips.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/mips/lithium-mips.cc View 3 chunks +18 lines, -34 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kisg
Please land the following commits together to avoid build errors: http://codereview.chromium.org/8384021/ http://codereview.chromium.org/8428004/ http://codereview.chromium.org/8387044/ http://codereview.chromium.org/8432010/ Thank ...
9 years, 1 month ago (2011-10-31 20:28:48 UTC) #1
kisg
On 2011/10/31 20:28:48, kisg wrote: > Please land the following commits together to avoid build ...
9 years, 1 month ago (2011-10-31 21:20:47 UTC) #2
fschneider
9 years, 1 month ago (2011-11-01 16:07:30 UTC) #3
LGTM.

I'll land it from here.

Powered by Google App Engine
This is Rietveld 408576698