Refactor IqRequest.

remoting/jingle_glue/iq_sender_unittest.cc

Index: remoting/jingle_glue/iq_sender_unittest.cc
diff --git a/remoting/jingle_glue/iq_sender_unittest.cc b/remoting/jingle_glue/iq_sender_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1bc706b02664a82f99eca23cef4eebfc685d2ca6
--- /dev/null
+++ b/remoting/jingle_glue/iq_sender_unittest.cc
@@ -0,0 +1,101 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/bind.h"
+#include "base/memory/ref_counted.h"
+#include "base/stringprintf.h"
+#include "remoting/jingle_glue/iq_sender.h"
+#include "remoting/jingle_glue/mock_objects.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/libjingle/source/talk/xmllite/xmlelement.h"
+#include "third_party/libjingle/source/talk/xmpp/constants.h"
+
+using ::testing::_;
+using ::testing::DeleteArg;
+using ::testing::NotNull;
+using ::testing::Return;
+using ::testing::SaveArg;
+
+using ::buzz::QName;
+using ::buzz::XmlElement;
+
+namespace remoting {
+
+namespace {
+
+const char kMessageId[] = "0";
+const char kNamespace[] = "chromium:testns";
+const char kNamespacePrefix[] = "tes";
+const char kBodyTag[] = "test";
+const char kType[] = "get";
+const char kTo[] = "user@domain.com";
+const char kStanzaId[] = "123";
+
+class MockCallback {
+ public:
+  MOCK_METHOD1(OnReply, void(const XmlElement* reply));
+};
+
+}  // namespace
+
+class IqSenderTest : public testing::Test {
+ public:
+  IqSenderTest() {
+    EXPECT_CALL(signal_strategy_, AddListener(NotNull()));
+    sender_.reset(new IqSender(&signal_strategy_));
+    EXPECT_CALL(signal_strategy_, RemoveListener(
+        static_cast<SignalStrategy::Listener*>(sender_.get())));
+  }
+
+ protected:
+  MockSignalStrategy signal_strategy_;
+  scoped_ptr<IqSender> sender_;
+  MockCallback callback_;
+};
+
+TEST_F(IqSenderTest, MakeIqStanza) {
+  std::string expected_xml_string =
+      base::StringPrintf(
+          "<cli:iq type=\"%s\" to=\"%s\" id=\"%s\" "
+          "xmlns:cli=\"jabber:client\">"
+          "<%s:%s xmlns:%s=\"%s\"/>"
+          "</cli:iq>",
+          kType, kTo, kMessageId, kNamespacePrefix, kBodyTag,
+          kNamespacePrefix, kNamespace);

[Wez, 2011/11/03 02:09:30]

nit: This entire stanza could be a constant, couldn't it?

[Sergey Ulanov, 2011/11/03 02:41:31]

Yes, but it means we would duplicate some data. Don't think it matters much.

+
+  XmlElement* iq_body =
+      new XmlElement(QName(kNamespace, kBodyTag));
+  scoped_ptr<XmlElement> stanza(
+      IqSender::MakeIqStanza(kType, kTo, iq_body));
+  stanza->AddAttr(QName("", "id"), kMessageId);
+
+  EXPECT_EQ(expected_xml_string, stanza->Str());
+}
+
+TEST_F(IqSenderTest, SendIq) {
+  XmlElement* iq_body =
+      new XmlElement(QName(kNamespace, kBodyTag));
+  XmlElement* stanza =
+      IqSender::MakeIqStanza(kType, kTo, iq_body);
+  EXPECT_CALL(signal_strategy_, GetNextId())
+      .WillOnce(Return(kStanzaId));
+  EXPECT_CALL(signal_strategy_, SendStanza(_))
+      .WillOnce(DoAll(DeleteArg<0>(), Return(true)));
+  sender_->SendIq(stanza, base::Bind(&MockCallback::OnReply,
+                                     base::Unretained(&callback_)));
+
+  scoped_ptr<XmlElement> response(new XmlElement(buzz::QN_IQ));
+  response->AddAttr(QName("", "type"), "result");
+  response->AddAttr(QName("", "id"), kStanzaId);
+
+  XmlElement* result = new XmlElement(
+      QName("test:namespace", "response-body"));
+  response->AddElement(result);
+
+  EXPECT_CALL(callback_, OnReply(response.get()));
+  EXPECT_TRUE(sender_->OnIncomingStanza(response.get()));
+}
+
+}  // namespace remoting