Issue 8432001: Tweaks whether Show activates the window or not. I'm pretty sure this

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8432001: Tweaks whether Show activates the window or not. I'm pretty sure this (Closed)

Created:
9 years, 1 month ago by sky

Modified:
9 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Tweaks whether Show activates the window or not. I'm pretty sure this better matches expectations. BUG=none TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108071

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merge to trunk #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	views/widget/native_widget_aura.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	views/widget/native_widget_aura.cc	View	1	3 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

9 years, 1 month ago (2011-10-31 18:31:39 UTC) #2

LGTM, looks like you'll need to land your other CL first since it comingles
withthis one.

http://codereview.chromium.org/8432001/diff/1/views/widget/native_widget_aura.cc
File views/widget/native_widget_aura.cc (right):

http://codereview.chromium.org/8432001/diff/1/views/widget/native_widget_aura...
views/widget/native_widget_aura.cc:340: window_->Activate();
braces around this block

Expand Messages | Collapse Messages