Implement async file API on top of isolates.

Implement async file API on top of isolates.

This is not going to be efficient but will give us the right
semantics of the operations. We should be using native async
operations for this.

Fixed a bug in VM implementation of List.setRange.

R=sgjesse@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=1012

[Søren Gjesse, 2011-11-01 13:22:49]

lgtm

http://codereview.chromium.org/8431028/diff/2001/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

http://codereview.chromium.org/8431028/diff/2001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:93: 
Instead of using a Map for the operations one could consider using:

class FileOperation {
  static int EXISTS = 0;
  static int OPEN = 1;
  ...

  abstract int get type();
  var reply;
}

class FileExitsOperation {
  FileExitsOperation(String this._name);
  int get type() => FileOperation.EXISTS
  String get name() => _name;
  String _name;
}

class FileOpenOperation {
  FileOpenOperation(String this._name);
  int get type() => FileOperation.OPEN
  String get name() => _name;
  String _name;
}

...

http://codereview.chromium.org/8431028/diff/2001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:155: var buffer = new List(bytes);
Can't we just call writeByteSync in a try catch block and reply with the
exception if any? Now we are duplicating the arguments checking.

http://codereview.chromium.org/8431028/diff/2001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:312: "mixed use of synchronous and asynchronous
API");
Uppercase M in mixed.

http://codereview.chromium.org/8431028/diff/2001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:423: var errorHandler =
is "var errorHandler" actually used?

http://codereview.chromium.org/8431028/diff/2001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:507: var errorHandler =
var errorHandler used?

http://codereview.chromium.org/8431028/diff/2001/tests/standalone/src/FileTes...
File tests/standalone/src/FileTest.dart (right):

http://codereview.chromium.org/8431028/diff/2001/tests/standalone/src/FileTes...
tests/standalone/src/FileTest.dart:124: static int testReadWrite() {
As discussed offline add an error handler to ensure that no error is
encountered. That goes for all async tests.

[Mads Ager (google), 2011-11-01 14:04:31]

http://codereview.chromium.org/8431028/diff/2001/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

http://codereview.chromium.org/8431028/diff/2001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:93: 
On 2011/11/01 13:22:49, Søren Gjesse wrote:
> Instead of using a Map for the operations one could consider using:
> 
> class FileOperation {
>   static int EXISTS = 0;
>   static int OPEN = 1;
>   ...
> 
>   abstract int get type();
>   var reply;
> }
> 
> class FileExitsOperation {
>   FileExitsOperation(String this._name);
>   int get type() => FileOperation.EXISTS
>   String get name() => _name;
>   String _name;
> }
> 
> class FileOpenOperation {
>   FileOpenOperation(String this._name);
>   int get type() => FileOperation.OPEN
>   String get name() => _name;
>   String _name;
> }
> 
> ...

Yes, that would be cleaner. I would like to do that in a separate change.

http://codereview.chromium.org/8431028/diff/2001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:155: var buffer = new List(bytes);
On 2011/11/01 13:22:49, Søren Gjesse wrote:
> Can't we just call writeByteSync in a try catch block and reply with the
> exception if any? Now we are duplicating the arguments checking.

Unfortunately not. In order to call writeByteSync we would need the file object.
I will extract read/write list parameter checking into a separate function to
share the code.

http://codereview.chromium.org/8431028/diff/2001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:312: "mixed use of synchronous and asynchronous
API");
On 2011/11/01 13:22:49, Søren Gjesse wrote:
> Uppercase M in mixed.

Thanks, done throughout the file.

http://codereview.chromium.org/8431028/diff/2001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:423: var errorHandler =
On 2011/11/01 13:22:49, Søren Gjesse wrote:
> is "var errorHandler" actually used?

Done.

http://codereview.chromium.org/8431028/diff/2001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:507: var errorHandler =
On 2011/11/01 13:22:49, Søren Gjesse wrote:
> var errorHandler used?

Done.

http://codereview.chromium.org/8431028/diff/2001/tests/standalone/src/FileTes...
File tests/standalone/src/FileTest.dart (right):

http://codereview.chromium.org/8431028/diff/2001/tests/standalone/src/FileTes...
tests/standalone/src/FileTest.dart:124: static int testReadWrite() {
On 2011/11/01 13:22:49, Søren Gjesse wrote:
> As discussed offline add an error handler to ensure that no error is
> encountered. That goes for all async tests.

Done.