Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 8431023: Suppresses leaks in tracked_objects. (Closed)

Created:
9 years, 1 month ago by Hironori Bono
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Suppresses leaks in tracked_objects. This change adds a rule that suppresses probably-intentional leaks caused by r108026 <http://crrev.com/108026>;. TBR=jar BUG=102327 TEST=make the "Linux Tests (valgrind)(2)" bot green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108068

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +8 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Hironori Bono
Greetings jar, Is it possible to check if this leak is your intentional one? Regards, ...
9 years, 1 month ago (2011-11-01 03:15:20 UTC) #1
jar (doing other things)
9 years, 1 month ago (2011-11-01 03:55:15 UTC) #2
LGTM

http://codereview.chromium.org/8431023/diff/1/tools/valgrind/memcheck/suppres...
File tools/valgrind/memcheck/suppressions.txt (right):

http://codereview.chromium.org/8431023/diff/1/tools/valgrind/memcheck/suppres...
tools/valgrind/memcheck/suppressions.txt:5207:
fun:_ZN15tracked_objects10ThreadData29ShutdownSingleThreadedCleanupEb
This is an excellent example of a race to supress.

This Shutdown... function is *ONLY* called in unit tests, and hence it is
possible that other threads, lingering from previous tests, are racing to see
status as this unit test runs.  As a result, this is an artifact of the unit
test only, and will *NEVER* take place in Chrome (the browser). 

In addition, the examination of status (raced against the setting of status) is
inconsequential, as the code handles any of the status values, in any order,
over time.  Hence any read is old or new values is handled gracefully.

Bottom line: Totally benign race.

Thanks for adding this.

Powered by Google App Engine
This is Rietveld 408576698