Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Issue 8431021: Handle cases where '.' show up in svn status and is deleted (Closed)

Created:
9 years, 1 month ago by M-A Ruel
Modified:
9 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Handle cases where '.' show up in svn status and is deleted This would cause random try job failures, especially when switching around DEPS <-> svn directory conversion. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108144

Patch Set 1 #

Patch Set 2 : Add another test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M gclient_scm.py View 1 chunk +5 lines, -0 lines 0 comments Download
M scm.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/gclient_scm_test.py View 1 3 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years, 1 month ago (2011-11-01 01:25:52 UTC) #1
Dirk Pranke
I think I follow the problem and the fix; can you add an explicit test ...
9 years, 1 month ago (2011-11-01 01:29:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8431021/1005
9 years, 1 month ago (2011-11-01 18:59:55 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-01 19:05:52 UTC) #4
Change committed as 108144

Powered by Google App Engine
This is Rietveld 408576698