Linux: Use the existing desktop environment detection code in mime_util_xdg.cc instead of its own...

Linux: Use the existing desktop environment detection code in mime_util_xdg.cc instead of its own version. Also fix a case where we look up bad icon names.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108185

[willchan no longer on Chromium, 2011-11-01 20:54:49]

http://codereview.chromium.org/8431018/diff/1/base/mime_util_xdg.cc
File base/mime_util_xdg.cc (right):

http://codereview.chromium.org/8431018/diff/1/base/mime_util_xdg.cc#newcode623
base/mime_util_xdg.cc:623: if (x_substr_pos != std::string::npos) {
This is a new change that isn't explained by the changelist description. Can you
explain why this is necessary? It seems reasonable at a glance, I just want to
doublecheck.

[Lei Zhang, 2011-11-01 21:03:29]

http://codereview.chromium.org/8431018/diff/1/base/mime_util_xdg.cc
File base/mime_util_xdg.cc (right):

http://codereview.chromium.org/8431018/diff/1/base/mime_util_xdg.cc#newcode623
base/mime_util_xdg.cc:623: if (x_substr_pos != std::string::npos) {
On 2011/11/01 20:54:49, willchan wrote:
> This is a new change that isn't explained by the changelist description. Can
you
> explain why this is necessary? It seems reasonable at a glance, I just want to
> doublecheck.

This is the "Also fix a case where we look up bad icon names" part.

For a mime type of "application/x-deb", we try to look up an icon with the name
"deb". However, if the input mime type doesn't have "/x-", e.g. "image/png",
right now we try to look up a bad icon name.

[willchan no longer on Chromium, 2011-11-01 21:04:15]

lgtm

http://codereview.chromium.org/8431018/diff/1/base/mime_util_xdg.cc
File base/mime_util_xdg.cc (right):

http://codereview.chromium.org/8431018/diff/1/base/mime_util_xdg.cc#newcode623
base/mime_util_xdg.cc:623: if (x_substr_pos != std::string::npos) {
On 2011/11/01 21:03:29, Lei Zhang wrote:
> On 2011/11/01 20:54:49, willchan wrote:
> > This is a new change that isn't explained by the changelist description. Can
> you
> > explain why this is necessary? It seems reasonable at a glance, I just want
to
> > doublecheck.
> 
> This is the "Also fix a case where we look up bad icon names" part.
> 
> For a mime type of "application/x-deb", we try to look up an icon with the
name
> "deb". However, if the input mime type doesn't have "/x-", e.g. "image/png",
> right now we try to look up a bad icon name.

Sorry, I missed that. Explanation sounds great.

[commit-bot: I haz the power, 2011-11-01 21:07:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/8431018/1

[commit-bot: I haz the power, 2011-11-01 22:24:39]

Change committed as 108185