fix some tests

tests/language/src/Library2NegativeTest.dart

Index: tests/language/src/Library2NegativeTest.dart
diff --git a/tests/language/src/Library2NegativeTest.dart b/tests/language/src/Library2NegativeTest.dart
index c92b52abb2656882a8f0cc5303706f8f6cda6818..0d1a7d025944cc07079d4d58ec9c0a6eef3ed1fa 100644
--- a/tests/language/src/Library2NegativeTest.dart
+++ b/tests/language/src/Library2NegativeTest.dart
@@ -8,6 +8,7 @@
 #library("Library2NegativeTest.dart");
 #import("library3.dart");  // imports library2.dart which defines foo/foo1.
 #import("library4.dart");  // imports library2.dart and defines foo/foo1.
+#import("library2.dart");

[jimhug, 2011/10/31 23:36:31]

This seems totally broken to me without this line.  Imports are not transitive
so members that are imported by library3 or library4 should not be exposed to
classes that import them.  If anything, I think it could be valuable to keep the
old version of this test around as a positive test since both dartc and the vm
appear to be generating an error here.

[ngeoffray, 2011/11/01 08:17:34]

The problem is that the libraries are not imported with a prefix. So if you do a
full analysis of what is in the scope of that file, you'll end up with two
definitions of 'foo'.

[kasperl, 2011/11/01 11:11:29]

To me it looks like importing library4 alone is enough to give us the issue
(library4 defines foo and imports foo from library2). Shouldn't this fail the
same way if you remove the library3 importing?

[jimhug, 2011/11/01 15:07:11]

Here's my take:

Importing just library4 and then accessing foo from within library4 would be an
error.  However, just importing library4 and then accessing foo from this file
should work correctly and return the foo defined in library4.  Am I missing
something?  Related: The library3 import in this file is not needed and I just
left it in in order to keep my changes minimal (hi, Nicolas <smile>)  the change
would be better if that was removed too.

On 2011/11/01 11:11:29, kasperl wrote:

[ngeoffray, 2011/11/01 15:18:31]

OK, I re-checked the source files. I think Kasper's right. library4 can not be
compiled properly because of duplicate definition of 'foo' and 'foo1'. I don't
know wrt the spec if we can delay the error reporting.

 
 main() {
   Expect.equals(0, foo1);