tests/language/src/Library3NegativeTest.dart - Issue 8431016: fix some tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/language/src/Library3NegativeTest.dart

Issue 8431016: fix some tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« tests/language/src/Library2NegativeTest.dart ('K') | « tests/language/src/Library2NegativeTest.dart ('k') | tests/language/src/OverrideFieldMethod1NegativeTest.dart » ('j') | tests/language/src/OverrideFieldMethod1NegativeTest.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 // This test should fail to load because we are importing two libraries	5 // This test should fail to load because we are importing two libraries

6 // which define the same top level name. In this case libraryE.dart is	6 // which define the same top level name. In this case libraryE.dart is

7 // importing libraryC.dart and libraryF.dart which both define variable	7 // importing libraryC.dart and libraryF.dart which both define variable

8 // "fooC".	8 // "fooC".
	ngeoffray 2011/11/01 08:17:34 The comment is right, and you should not need to r The comment is right, and you should not need to replace fooE to foo (which I believe is not defined?) jimhug 2011/11/01 15:07:11 This is a typo in my code and I agree that this sh This is a typo in my code and I agree that this should be fooE as you say. However, there is a key change that I made in libraryE - that I believe should be required to ensure the checks happen. On 2011/11/01 08:17:34, ngeoffray wrote: Show quoted text > The comment is right, and you should not need to replace fooE to foo (which I > believe is not defined?)
9	9

10 #library("Library3NegativeTest.dart");	10 #library("Library3NegativeTest.dart");

11 #import("libraryA.dart");	11 #import("libraryA.dart");

12 #import("libraryB.dart");	12 #import("libraryB.dart");

13 #import("libraryD.dart");	13 #import("libraryD.dart");

14 #import("libraryE.dart");	14 #import("libraryE.dart");

15	15

16 main() {	16 main() {

17 Expect.equals(0, fooE);	17 Expect.equals(0, foo);
	jimhug 2011/11/01 15:07:11 Fix this back to fooE. Fix this back to fooE.
18 }	18 }

OLD	NEW