Issue 8431014: Update LocalState pyauto calls to work without first browser window

Issue 8431014: Update LocalState pyauto calls to work without first browser window (Closed)

Created:
9 years, 1 month ago by Nirnimesh

Modified:
9 years, 1 month ago

Reviewers:
dennis_jeffrey, Miranda Callahan

CC:
chromium-reviews, Nirnimesh, John Grabowski, kkania, anantha, robertshield, dyu1, Paweł Hajdan Jr., dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Update LocalState pyauto calls to work without first browser window Update pyauto calls GetLocalStatePrefsInfo/SetLocalStatePrefs so that it does not require first browser window to be present. This is so that it can be used at chromeos login screen (when first browser window is not up) BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108125

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : indent #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -12 lines)			Patch
M	chrome/browser/automation/testing_automation_provider.h	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View		4 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/test/functional/prefs.py	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/test/pyautolib/pyauto.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dennis_jeffrey

drive-by nit http://codereview.chromium.org/8431014/diff/1001/chrome/test/functional/prefs.py File chrome/test/functional/prefs.py (right): http://codereview.chromium.org/8431014/diff/1001/chrome/test/functional/prefs.py#newcode193 chrome/test/functional/prefs.py:193: self.assertTrue(self.GetLocalStatePrefsInfo()) nit: indent the above 2 lines ...

9 years, 1 month ago (2011-10-31 22:32:21 UTC) #2

Nirnimesh

http://codereview.chromium.org/8431014/diff/1001/chrome/test/functional/prefs.py File chrome/test/functional/prefs.py (right): http://codereview.chromium.org/8431014/diff/1001/chrome/test/functional/prefs.py#newcode193 chrome/test/functional/prefs.py:193: self.assertTrue(self.GetLocalStatePrefsInfo()) On 2011/10/31 22:32:22, dennis_jeffrey wrote: > nit: indent ...

9 years, 1 month ago (2011-10-31 23:29:49 UTC) #3

Miranda Callahan

9 years, 1 month ago (2011-11-01 13:03:31 UTC) #4

On 2011/10/31 23:29:49, Nirnimesh wrote:
>
http://codereview.chromium.org/8431014/diff/1001/chrome/test/functional/prefs.py
> File chrome/test/functional/prefs.py (right):
> 
>
http://codereview.chromium.org/8431014/diff/1001/chrome/test/functional/prefs...
> chrome/test/functional/prefs.py:193:
> self.assertTrue(self.GetLocalStatePrefsInfo())
> On 2011/10/31 22:32:22, dennis_jeffrey wrote:
> > nit: indent the above 2 lines by 2 fewer spaces each
> 
> Ah.. autotest python indent system has damaged my brain.
> Fixed.

LGTM!

Expand Messages | Collapse Messages