Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: src/variables.cc

Issue 8431001: Tune context allocation for variables accessed from inner scopes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/variables.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 bool is_valid_LHS, 60 bool is_valid_LHS,
61 Kind kind) 61 Kind kind)
62 : scope_(scope), 62 : scope_(scope),
63 name_(name), 63 name_(name),
64 mode_(mode), 64 mode_(mode),
65 kind_(kind), 65 kind_(kind),
66 location_(UNALLOCATED), 66 location_(UNALLOCATED),
67 index_(-1), 67 index_(-1),
68 local_if_not_shadowed_(NULL), 68 local_if_not_shadowed_(NULL),
69 is_valid_LHS_(is_valid_LHS), 69 is_valid_LHS_(is_valid_LHS),
70 is_accessed_from_inner_scope_(false), 70 force_context_allocation_(false),
71 is_used_(false) { 71 is_used_(false) {
72 // names must be canonicalized for fast equality checks 72 // names must be canonicalized for fast equality checks
73 ASSERT(name->IsSymbol()); 73 ASSERT(name->IsSymbol());
74 } 74 }
75 75
76 76
77 bool Variable::is_global() const { 77 bool Variable::is_global() const {
78 // Temporaries are never global, they must always be allocated in the 78 // Temporaries are never global, they must always be allocated in the
79 // activation frame. 79 // activation frame.
80 return mode_ != TEMPORARY && scope_ != NULL && scope_->is_global_scope(); 80 return mode_ != TEMPORARY && scope_ != NULL && scope_->is_global_scope();
81 } 81 }
82 82
83 } } // namespace v8::internal 83 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/variables.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698