Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 8431001: Tune context allocation for variables accessed from inner scopes. (Closed)

Created:
9 years, 1 month ago by Steven
Modified:
9 years, 1 month ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Tune context allocation for variables accessed from inner scopes. After introduction of with scopes we have enough static information to omit context allocation in the case that a variable is accessed from a nested block or catch scope of the same function. Only variables accessed from the inside of a nested function or with scope are forced to be allocated in the context. This essentially reverts http://code.google.com/p/v8/source/detail?r=9281 . which in turn reverted an earlier change. Committed: http://code.google.com/p/v8/source/detail?r=9872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M src/scopes.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M src/variables.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/variables.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Steven
PTAL.
9 years, 1 month ago (2011-10-31 15:03:19 UTC) #1
fschneider
9 years, 1 month ago (2011-11-03 13:18:26 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698