Issue 8430022: Histogram how often IDENT_SRC_URL is used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8430022: Histogram how often IDENT_SRC_URL is used. (Closed)

Created:
9 years, 1 month ago by Tom Sepez

Modified:
9 years, 1 month ago

Reviewers:
cbentzel, cevans, jar (doing other things), eroman

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Histogram how often IDENT_SRC_URL is used. We believe that IE7 and above no longer support user:pass@host inside urls. We shouldn't either, but first get data on how often this is hit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108150

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	net/http/http_auth_controller.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

Added cross-section of reviewers from net/OWNERS. Please take a look. Thanks.

9 years, 1 month ago (2011-11-01 00:11:16 UTC) #1

cbentzel

LGTM. Do you want to get a ratio for relative rates [i.e. this only happens ...

9 years, 1 month ago (2011-11-01 13:01:46 UTC) #3

Tom Sepez

9 years, 1 month ago (2011-11-01 19:19:20 UTC) #4

On 2011/11/01 13:01:46, cbentzel wrote:
> LGTM.
> 
> Do you want to get a ratio for relative rates [i.e. this only happens 1 out
> of N auth attempts] or are you looking for absolute rates?
> 
> On Tue, Nov 1, 2011 at 1:19 AM, <mailto:jar@chromium.org> wrote:
> 
> > lgtm
> >
> >
> >
> >
>
http://codereview.chromium.**org/8430022/%3Chttp://codereview.chromium.org/84...>
> >

Looking for count of users that hit this.

Expand Messages | Collapse Messages