Issue 8430015: Adding transition to kPlaying when end of stream is reached during an underflow.

Issue 8430015: Adding transition to kPlaying when end of stream is reached during an underflow. (Closed)

Created:
9 years, 1 month ago by acolwell GONE FROM CHROMIUM

Modified:
9 years, 1 month ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Adding transition to kPlaying when end of stream is reached during an underflow. BUG=92254 TEST=AudioRendererBaseTest::Underflow_EndOfStream Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108191

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit #

Patch Set 3 : Fix windows build buster #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -31 lines)			Patch
	M	media/filters/audio_renderer_base.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	media/filters/audio_renderer_base_unittest.cc	View	1 2	4 chunks	+109 lines, -31 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

LGTM w/ one nit was this an actual bug? http://codereview.chromium.org/8430015/diff/1/media/filters/audio_renderer_base_unittest.cc File media/filters/audio_renderer_base_unittest.cc (right): http://codereview.chromium.org/8430015/diff/1/media/filters/audio_renderer_base_unittest.cc#newcode393 media/filters/audio_renderer_base_unittest.cc:393: ...

9 years, 1 month ago (2011-10-31 22:52:50 UTC) #2

acolwell GONE FROM CHROMIUM

http://codereview.chromium.org/8430015/diff/1/media/filters/audio_renderer_base_unittest.cc File media/filters/audio_renderer_base_unittest.cc (right): http://codereview.chromium.org/8430015/diff/1/media/filters/audio_renderer_base_unittest.cc#newcode393 media/filters/audio_renderer_base_unittest.cc:393: // Write a buffer On 2011/10/31 22:52:50, scherkus wrote: ...

9 years, 1 month ago (2011-11-01 21:54:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/8430015/5003

9 years, 1 month ago (2011-11-01 21:54:44 UTC) #4

Change committed as 108191

Expand Messages | Collapse Messages