Split Mac WebDropTarget into two, content and chrome.

Split Mac WebDropTarget into two, content and chrome.

BUG=95573
TEST=no visible change

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108113

[Avi (use Gerrit), 2011-10-31 20:18:25]

You're as much of a mac guy as we have here on content.

[jochen (gone - plz use gerrit), 2011-11-01 15:16:06]

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/tab_contents_view_mac.h (right):

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/tab_contents_view_mac.h:42:
scoped_ptr<WebDragBookmarkHandlerMac> bookmark_handler_;
nit. maybe rename the other variables for consistency?

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/web_drag_bookmark_handler_mac.h (right):

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/web_drag_bookmark_handler_mac.h:22: // Overridden
from WebDragBookmarkDelegate:
from WebDragDestDelegate?

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/web_drag_bookmark_handler_mac.h:38: };
disallow copy & assign?

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm (right):

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm:18: void
WebDragBookmarkHandlerMac::DragInitialize(TabContents* contents) {
maybe DCHECK that contents and tab are the same if tab_ != NULL?

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm:26: if (tab_ &&
tab_->bookmark_tab_helper()->GetBookmarkDragDelegate())
brackets since if-body >= 1 line

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm:32: if (tab_ &&
tab_->bookmark_tab_helper()->GetBookmarkDragDelegate())
same here

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm:55: if (tab_ &&
tab_->bookmark_tab_helper()->GetBookmarkDragDelegate())
and here

[Avi (use Gerrit), 2011-11-01 16:01:06]

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/tab_contents_view_mac.h (right):

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/tab_contents_view_mac.h:42:
scoped_ptr<WebDragBookmarkHandlerMac> bookmark_handler_;
On 2011/11/01 15:16:07, jochen wrote:
> nit. maybe rename the other variables for consistency?

Actually, this one is named wrong. Fixing.

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/web_drag_bookmark_handler_mac.h (right):

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/web_drag_bookmark_handler_mac.h:22: // Overridden
from WebDragBookmarkDelegate:
On 2011/11/01 15:16:07, jochen wrote:
> from WebDragDestDelegate?

sigh. fixing everywhere.

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/web_drag_bookmark_handler_mac.h:38: };
On 2011/11/01 15:16:07, jochen wrote:
> disallow copy & assign?

yep.

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm (right):

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm:18: void
WebDragBookmarkHandlerMac::DragInitialize(TabContents* contents) {
On 2011/11/01 15:16:07, jochen wrote:
> maybe DCHECK that contents and tab are the same if tab_ != NULL?

Done.

http://codereview.chromium.org/8430013/diff/1001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm:26: if (tab_ &&
tab_->bookmark_tab_helper()->GetBookmarkDragDelegate())
On 2011/11/01 15:16:07, jochen wrote:
> brackets since if-body >= 1 line

will fix in source too

[jochen (gone - plz use gerrit), 2011-11-01 16:10:42]

LGTM