Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 8430004: Revert 107895 - Fully enable about:tracking by default (Closed)

Created:
9 years, 1 month ago by joth
Modified:
9 years, 1 month ago
CC:
chromium-reviews, sadrul, brettw-cc_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 107895 - Fully enable about:tracking by default This is a re-land of: http://codereview.chromium.org/8391019/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107793 Original landing had trouble with message_loop_x.h, due to header include ordering. I pulled out the structure that was really needed by tracked_objects.h into a new file tracked_info.*. This allows tracked_objects to inlude this tracked_info, but not have to include the message_loop.h totality. I also removed a DCHECK that that was triggering on a test, and added yet one more file (browser_main.cc) where I removed a #ifdef for TRACKING_ALL_OBJECTS. The changes were minor, and I'm hoping to get clear perf runs with tihs landing, so I'm going to TBR it and reland early in the morning. Comments from original landing: Support is now controlled by the flag: --enable-tracking and the default is always on. To turn it off, use: --enable-tracking=0 All profiler code is compiled now in release and official builds (in addition to debug, where it was already active), but most entry points can be disabled (turned into no-ops) by a single const bool setting atop tracked_objects.cc (in case folks want to revert the perf-impact of this change). Transition to faster Now() service on Windows for the profiler use only. The TimeTicks::Now() function on Window uses locking to get a 64 bit time value. This CL transitions times used for profiling to more directly use a 32 bit Time interface, which is actually what drives the 64 bit TimeTicks. By using the smaller value, we avoid the need for locks, or even atomic operations for the most part in the tracking system. On linux, we just down-sample the standard TimeTicks to 32 bits for consistency (clean ability to snapshot asyncronously without atomics... but I should verify that such is helpful to performance). I've also put in yet more cleanup and refactoring. tbr=rtenneti bug=101856 Review URL: http://codereview.chromium.org/8414036 TBR=jar@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -776 lines) Patch
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M base/location.h View 1 chunk +6 lines, -0 lines 0 comments Download
M base/message_loop.h View 4 chunks +14 lines, -2 lines 0 comments Download
M base/message_loop.cc View 2 chunks +14 lines, -6 lines 0 comments Download
M base/threading/thread.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/threading/worker_pool_posix.h View 1 chunk +4 lines, -2 lines 0 comments Download
M base/threading/worker_pool_posix.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M base/threading/worker_pool_win.cc View 2 chunks +15 lines, -9 lines 0 comments Download
M base/tracked_objects.h View 21 chunks +67 lines, -187 lines 0 comments Download
M base/tracked_objects.cc View 18 chunks +131 lines, -177 lines 0 comments Download
M base/tracked_objects_unittest.cc View 12 chunks +99 lines, -292 lines 0 comments Download
D base/tracking_info.h View 1 chunk +0 lines, -41 lines 0 comments Download
D base/tracking_info.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 5 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/chrome_switches.h View 3 chunks +1 line, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 3 chunks +9 lines, -16 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
joth
9 years, 1 month ago (2011-10-31 15:31:26 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698