Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 8430003: Revert 107939 - Pile of nits for tracked object enablement (Closed)

Created:
9 years, 1 month ago by joth
Modified:
9 years, 1 month ago
CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 107939 - Pile of nits for tracked object enablement [Re-land of Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107921 with supressions for induced (and planned) leaks) PLUS Removed one line of defensive coding where I set(NULL) the TLS slote at thread teardown. We're seeing strange failures on the base unittests, and they may be related to this. ] Be extra carful about handling races in access to status_. This will avoid generating a delta between a null time and a real time, when status is changing in/around the run of a task. This won't help with the benign race for checking status_, but it may help with unit test tsan complaints. Leak data aggressively, rather than cleaning up, to prevent any chance of a data access race between tracked object testing (which need a near-virgin global state, and hence must start by cleaning it up), and other tests, which may have lingering threaded actions, that still access some previously created task tracking data. Provide more options for flags to enable/disable tracking. These options might become useful if we changed the default to not do tracking. Allow for HTML generation even if the tracking has changed to being disabled. This is especially useful for looking at the tracked instances that were monitored after turning tracking on by default, but before the command line deactiated tracking. tbr=rtenneti bug=102327 Review URL: http://codereview.chromium.org/8425010 TBR=jar@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107960

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -57 lines) Patch
M base/tracked_objects.cc View 7 chunks +13 lines, -36 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
joth
9 years, 1 month ago (2011-10-31 15:28:51 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698