Issue 8430001: Add "Graphics backend" line to chrome://gpu-internals page

Issue 8430001: Add "Graphics backend" line to chrome://gpu-internals page (Closed)

Created:
9 years, 1 month ago by epoger

Modified:
9 years, 1 month ago

Reviewers:
nduca

CC:
chromium-reviews, arv (Not doing code reviews), reed1, caryclark, bsalomon, tomhudson

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add "Graphics backend" line to chrome://gpu-internals page, indicating whether Skia is being used or not. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107987

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	chrome/browser/resources/gpu_internals/info_view.js	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/webui/gpu_internals_ui.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

epoger

Here are links to the trybots I ran: linux: http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/371 mac: http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/379 win: http://build.chromium.org/p/tryserver.chromium/builders/win/builds/447

9 years, 1 month ago (2011-10-31 15:23:41 UTC) #1

epoger

Nat- TomHudson said you would probably be a good guy to either review this small ...

9 years, 1 month ago (2011-10-31 17:12:44 UTC) #2

epoger

On 2011/10/31 17:12:44, epoger wrote: > Nat- TomHudson said you would probably be a good ...

9 years, 1 month ago (2011-10-31 17:13:29 UTC) #3

nduca

LGTM with some better word http://codereview.chromium.org/8430001/diff/1/chrome/browser/resources/gpu_internals/info_view.js File chrome/browser/resources/gpu_internals/info_view.js (right): http://codereview.chromium.org/8430001/diff/1/chrome/browser/resources/gpu_internals/info_view.js#newcode66 chrome/browser/resources/gpu_internals/info_view.js:66: description: 'Graphics backend', 2D ...

9 years, 1 month ago (2011-10-31 17:42:49 UTC) #4

epoger

9 years, 1 month ago (2011-10-31 17:50:02 UTC) #5

Thanks. Will commit once the tree opens up.

http://codereview.chromium.org/8430001/diff/1/chrome/browser/resources/gpu_in...
File chrome/browser/resources/gpu_internals/info_view.js (right):

http://codereview.chromium.org/8430001/diff/1/chrome/browser/resources/gpu_in...
chrome/browser/resources/gpu_internals/info_view.js:66: description: 'Graphics
backend',
On 2011/10/31 17:42:49, nduca wrote:
> 2D graphics backend? Graphics is a pretty overloaded word, yo!

Good point. Renamed to '2D graphics backend'.

Expand Messages | Collapse Messages