Upstream: Build net_unittests for Android.

net/base/dns_reloader.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/dns_reloader.h"
 
-#if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_OPENBSD)
+#if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_OPENBSD) && !defined(OS_ANDROID)

[joth, 2011/11/02 18:57:05]

uh! I wonder why this isn't using a .gyp rule to exclude?

Anyway, please wrap to 80 col

[Jing Zhao, 2011/11/03 17:49:08]

Done.

 
 #include <resolv.h>
 
 #include "base/basictypes.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/synchronization/lock.h"
 #include "base/threading/thread_local_storage.h"
 #include "net/base/network_change_notifier.h"
 
 namespace {
 
 // On Linux/BSD, changes to /etc/resolv.conf can go unnoticed thus resulting
 // in DNS queries failing either because nameservers are unknown on startup
 // or because nameserver info has changed as a result of e.g. connecting to
 // a new network. Some distributions patch glibc to stat /etc/resolv.conf
 // to try to automatically detect such changes but these patches are not
 // universal and even patched systems such as Jaunty appear to need calls
 // to res_ninit to reload the nameserver information in different threads.
 //
 // To fix this, on systems with FilePathWatcher support, we use
 // NetworkChangeNotifier::DNSObserver to monitor /etc/resolv.conf to
 // enable us to respond to DNS changes and reload the resolver state.
 //
 // OpenBSD does not have thread-safe res_ninit/res_nclose so we can't do
 // the same trick there and most *BSD's don't yet have support for
 // FilePathWatcher (but perhaps the new kqueue mac code just needs to be
 // ported to *BSD to support that).
 

[joth, 2011/11/02 18:57:05]

sounds like there should be an additional comment here about android (but I'm
not totally sure what it would say!)

[Jing Zhao, 2011/11/03 17:49:08]

I don't know either.. What I know is Android doesn't have res_ninit/res_nclose.
Do you know someone familiar with this?

[joth, 2011/11/03 19:45:02]

actually, looking at it again, I think it's pretty simple:
// Android does not have /etc/resolv.conf at all the system takes care of
nameserver changes, so none of this is not needed.
(This is not strictly OS_POSIX at all)

[Jing Zhao, 2011/11/04 08:01:43]

Added. Thanks for helping me out.

 class DnsReloader : public net::NetworkChangeNotifier::DNSObserver {
  public:
   struct ReloadState {
     int resolver_generation;
   };
 
   // NetworkChangeNotifier::OnDNSChanged methods:
   virtual void OnDNSChanged() OVERRIDE {
     DCHECK_EQ(MessageLoop::current()->type(), MessageLoop::TYPE_IO);
     base::AutoLock l(lock_);
@@ skipping 64 matching lines @@
 }
 
 void DnsReloaderMaybeReload() {
   // This routine can be called by any of the DNS worker threads.
   DnsReloader* dns_reloader = g_dns_reloader.Pointer();
   dns_reloader->MaybeReload();
 }
 
 }  // namespace net
 
-#endif  // defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_OPENBSD)
+#endif  // defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_OPENBSD) && !defined(OS_ANDROID)