Issue 8429029: add gtk dep to test_support_common

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8429029: add gtk dep to test_support_common (Closed)

Created:
9 years, 1 month ago by Dirk Pranke

Modified:
9 years, 1 month ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

add gtk dep to test_support_common R=erg@chromium.org BUG=90442 TEST=test_support_common compiles w/ content shared lib. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108156

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	content/content_tests.gypi	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

9 years, 1 month ago (2011-11-01 17:17:44 UTC) #2

LGTM

On Mon, Oct 31, 2011 at 5:55 PM,  <dpranke@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> add gtk dep to test_support_common
>
> R=erg@chromium.org
> BUG=90442
> TEST=test_support_common compiles w/ content shared lib.
>
>
> Please review this at http://codereview.chromium.org/8429029/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M content/content_tests.gypi
>
>
> Index: content/content_tests.gypi
> diff --git a/content/content_tests.gypi b/content/content_tests.gypi
> index
>
d0238e4d9b185fccc83f82f86541f92cf56d2cba..97e2bc0127cee956c0ee412e10143c9884efe36c
> 100644
> --- a/content/content_tests.gypi
> +++ b/content/content_tests.gypi
> @@ -95,6 +95,13 @@
>         '../webkit/quota/mock_special_storage_policy.cc',
>         '../webkit/quota/mock_special_storage_policy.h',
>       ],
> +      'conditions': [
> +        ['toolkit_uses_gtk == 1', {
> +          'dependencies': [
> +            '../build/linux/system.gyp:gtk',
> +          ],
> +        }],
> +      ],
>     },
>     {
>       'target_name': 'content_unittests',
>
>
>

Expand Messages | Collapse Messages