Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: runtime/lib/byte_buffer.cc

Issue 8429027: Add an external array type to support typed arrays. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address final review comments Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/byte_buffer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/byte_buffer.cc
diff --git a/runtime/lib/byte_buffer.cc b/runtime/lib/byte_buffer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..dd66926c56af33ff9c45a73aad2bfdd2ff30fd09
--- /dev/null
+++ b/runtime/lib/byte_buffer.cc
@@ -0,0 +1,246 @@
+// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#include "vm/bootstrap_natives.h"
+
+#include "vm/assembler.h"
+#include "vm/assert.h"
+#include "vm/bigint_operations.h"
+#include "vm/exceptions.h"
+#include "vm/native_entry.h"
+#include "vm/object.h"
+
+namespace dart {
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_allocate, 1) {
+ const Instance& length_instance = Instance::CheckedHandle(arguments->At(0));
+ if (!length_instance.IsSmi()) {
+ GrowableArray<const Object*> args;
+ args.Add(&length_instance);
+ Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+ }
+ Smi& length = Smi::Handle();
+ length ^= length_instance.raw();
+ if (length.Value() < 0) {
+ GrowableArray<const Object*> args;
+ args.Add(&length);
+ Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+ }
+ uint8_t* data = new uint8_t[length.Value()];
+ memset(data, 0, length.Value());
+ const ByteBuffer& new_array =
+ ByteBuffer::Handle(ByteBuffer::New(data, length.Value()));
+ arguments->SetReturn(new_array);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_getLength, 1) {
+ const ByteBuffer& array = ByteBuffer::CheckedHandle(arguments->At(0));
+ if (array.IsNull()) {
+ // TODO(asiva): Need to handle error cases.
+ UNIMPLEMENTED();
+ return;
+ }
+ const Smi& length = Smi::Handle(Smi::New(array.Length()));
+ arguments->SetReturn(length);
+}
+
+
+template<typename ValueType, typename ObjectType>
+static void GetIndexed(NativeArguments* arguments) {
+ const ByteBuffer& buffer = ByteBuffer::CheckedHandle(arguments->At(0));
+ const Instance& index_instance = Instance::CheckedHandle(arguments->At(1));
+ if (!index_instance.IsSmi()) {
+ GrowableArray<const Object*> args;
+ args.Add(&index_instance);
+ Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+ }
+ Smi& index = Smi::Handle();
+ index ^= index_instance.raw();
+ if (buffer.IsNull() || index.IsNull()) {
+ // TODO(asiva): Need to handle error cases.
+ UNIMPLEMENTED();
+ return;
+ }
+ intptr_t num_bytes = sizeof(ValueType);
+ if ((index.Value() < 0) || ((index.Value() + num_bytes) > buffer.Length())) {
+ GrowableArray<const Object*> arguments;
+ arguments.Add(&index);
+ Exceptions::ThrowByType(Exceptions::kIndexOutOfRange, arguments);
+ }
+ arguments->SetReturn(
+ ObjectType::Handle(
+ ObjectType::New(buffer.UnalignedAt<ValueType>(index.Value()))));
+}
+
+
+template<typename T> static bool HasType(const Object& obj);
+
+
+template<>
+bool HasType<Smi>(const Object& obj) {
+ return obj.IsSmi();
+}
+
+
+template<>
+bool HasType<Integer>(const Object& obj) {
+ return obj.IsInteger();
+}
+
+
+template<>
+bool HasType<Double>(const Object& obj) {
+ return obj.IsDouble();
+}
+
+
+static intptr_t Value(const Smi& obj) {
+ return obj.Value();
+}
+
+
+static int64_t Value(const Integer& obj) {
+ return obj.AsInt64Value();
+}
+
+
+static double Value(const Double& obj) {
+ return obj.value();
+}
+
+
+template<typename ValueType, typename ObjectType>
+static void SetIndexed(const NativeArguments* arguments) {
+ const ByteBuffer& buffer = ByteBuffer::CheckedHandle(arguments->At(0));
+ const Instance& index_instance = Instance::CheckedHandle(arguments->At(1));
+ if (!index_instance.IsSmi()) {
+ GrowableArray<const Object*> args;
+ args.Add(&index_instance);
+ Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+ }
+ Smi& index = Smi::Handle();
+ index ^= index_instance.raw();
+ const Instance& value_instance = Instance::CheckedHandle(arguments->At(2));
+ if (buffer.IsNull() || index.IsNull()) {
+ // TODO(asiva): Need to handle error cases.
+ UNIMPLEMENTED();
+ return;
+ }
+ if (index.Value() >= buffer.Length()) {
+ GrowableArray<const Object*> arguments;
+ arguments.Add(&index);
+ Exceptions::ThrowByType(Exceptions::kIndexOutOfRange, arguments);
+ }
+ if (!HasType<ObjectType>(value_instance)) {
+ GrowableArray<const Object*> args;
+ args.Add(&value_instance);
+ Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
+ }
+ ObjectType& value = ObjectType::Handle();
+ value ^= value_instance.raw();
+ buffer.SetUnalignedAt<ValueType>(index.Value(), Value(value));
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_getInt8, 2) {
+ GetIndexed<int8_t, Smi>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_setInt8, 3) {
+ SetIndexed<int8_t, Smi>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_getUint8, 2) {
+ GetIndexed<uint8_t, Smi>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_setUint8, 3) {
+ SetIndexed<uint8_t, Smi>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_getInt16, 2) {
+ GetIndexed<int16_t, Smi>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_setInt16, 3) {
+ SetIndexed<int16_t, Smi>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_getUint16, 2) {
+ GetIndexed<uint16_t, Smi>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_setUint16, 3) {
+ SetIndexed<uint16_t, Smi>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_getInt32, 2) {
+ GetIndexed<int32_t, Integer>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_setInt32, 3) {
+ SetIndexed<int32_t, Integer>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_getUint32, 2) {
+ GetIndexed<uint32_t, Integer>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_setUint32, 3) {
+ SetIndexed<uint32_t, Integer>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_getInt64, 2) {
+ GetIndexed<int64_t, Integer>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_setInt64, 3) {
+ SetIndexed<int64_t, Integer>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_getUint64, 2) {
+ UNIMPLEMENTED(); // TODO(cshapiro): need getter implementation.
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_setUint64, 3) {
+ UNIMPLEMENTED(); // TODO(cshapiro): need setter implementation.
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_getFloat32, 2) {
+ GetIndexed<float, Double>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_setFloat32, 3) {
+ SetIndexed<float, Double>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_getFloat64, 2) {
+ GetIndexed<double, Double>(arguments);
+}
+
+
+DEFINE_NATIVE_ENTRY(ByteBuffer_setFloat64, 3) {
+ SetIndexed<double, Double>(arguments);
+}
+
+} // namespace dart
« no previous file with comments | « no previous file | runtime/lib/byte_buffer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698