Add an external array type to support typed arrays.

runtime/vm/object.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "vm/assert.h"
 #include "vm/dart.h"
 #include "vm/globals.h"
@@ skipping 2776 matching lines @@
   static RawImmutableArray* New(intptr_t len, Heap::Space space = Heap::kNew) {
     return reinterpret_cast<RawImmutableArray*>(Array::New(len, true, space));
   }
 
  private:
   HEAP_OBJECT_IMPLEMENTATION(ImmutableArray, Array);
   friend class Class;
 };
 
 
+class ByteBuffer : public Instance {
+ public:
+  intptr_t Length() const {
+    ASSERT(!IsNull());
+    return Smi::Value(raw_ptr()->length_);
+  }
+
+  template<typename T>
+  T At(intptr_t byte_offset) const {
+    ASSERT(Utils::IsAligned(byte_offset, sizeof(T)));

[Ivan Posva, 2011/11/16 22:50:01]

Shouldn't this check for (base_address + byte_offset) to be aligned properly?
Put differently, this should also work:

T* addr = Addr<T>(byte_offset);
ASSERT(Utils::IsAligned(addr, sizeof(T));
return *addr;

[cshapiro, 2011/11/17 03:17:02]

It depends on whether the base address will ever be misaligned.  Either way, it
does not hurt to make the change you propose, so I will go ahead and
future-proof the code. Done.

+    return *Addr<T>(byte_offset);
+  }
+  template<typename T>
+  void SetAt(intptr_t byte_offset, T value) const {
+    ASSERT(Utils::IsAligned(byte_offset, sizeof(T)));

[Ivan Posva, 2011/11/16 22:50:01]

ditto

[cshapiro, 2011/11/17 03:17:02]

Done.

+    *Addr<T>(byte_offset) = value;
+  }
+
+  template<typename T>
+  T UnalignedAt(intptr_t byte_offset) const {
+    T result;
+    memmove(&result, Addr<T>(byte_offset), sizeof(T));
+    return result;
+  }
+  template<typename T>
+  void SetUnalignedAt(intptr_t byte_offset, T value) const {
+    memmove(Addr<T>(byte_offset), &value, sizeof(T));
+  }
+
+  virtual bool Equals(const Instance& other) const;
+
+  static intptr_t InstanceSize() {
+    return RoundedAllocationSize(sizeof(RawByteBuffer));
+  }
+
+  static RawByteBuffer* New(uint8_t* data,
+                            intptr_t len,
+                            Heap::Space space = Heap::kNew);
+
+ private:
+  template<typename T>
+  T* Addr(intptr_t byte_offset) const {
+    intptr_t limit = byte_offset + sizeof(T);
+    // TODO(iposva): Determine if we should throw an exception here.
+    ASSERT((byte_offset >= 0) && (limit <= Length()));
+    uint8_t* addr = &raw_ptr()->data_[byte_offset];
+    return reinterpret_cast<T*>(addr);
+  }
+
+  void SetLength(intptr_t value) {
+    raw_ptr()->length_ = Smi::New(value);
+  }
+
+  void SetData(uint8_t* data) const {
+    raw_ptr()->data_ = data;
+  }
+
+  HEAP_OBJECT_IMPLEMENTATION(ByteBuffer, Instance);
+  friend class Class;
+};
+
+
 class Closure : public Instance {
  public:
   RawFunction* function() const { return raw_ptr()->function_; }
   static intptr_t function_offset() {
     return OFFSET_OF(RawClosure, function_);
   }
 
   RawContext* context() const { return raw_ptr()->context_; }
   static intptr_t context_offset() { return OFFSET_OF(RawClosure, context_); }
 
@@ skipping 193 matching lines @@
 }
 
 
 void Context::SetAt(intptr_t index, const Instance& value) const {
   StorePointer(InstanceAddr(index), value.raw());
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_