Add an external array type to support typed arrays.

runtime/vm/object_test.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
@@ skipping 1575 matching lines @@
 
   other_array = Array::New(kArrayLen - 1);
   other_array.SetAt(0, array);
   other_array.SetAt(2, array);
   EXPECT(!array.Equals(other_array));
 
   EXPECT_EQ(0, Array::Handle(Array::Empty()).Length());
 }
 
 
+TEST_CASE(ExternalArray) {
+  uint8_t data[] = { 253, 254, 255, 0, 1, 2, 3 };
+  intptr_t data_length = ARRAY_SIZE(data);
+
+  const ExternalArray& array1 =
+      ExternalArray::Handle(ExternalArray::New(data, data_length));
+  EXPECT(!array1.IsNull());
+  EXPECT_EQ(data_length, array1.Length());
+  EXPECT_EQ(-3, array1.Int8At(0));
+  EXPECT_EQ(253, array1.Uint8At(0));
+  EXPECT_EQ(-2, array1.Int8At(1));
+  EXPECT_EQ(254, array1.Uint8At(1));
+  EXPECT_EQ(-1, array1.Int8At(2));
+  EXPECT_EQ(255, array1.Uint8At(2));
+  EXPECT_EQ(0, array1.Int8At(3));
+  EXPECT_EQ(0, array1.Uint8At(3));
+  EXPECT_EQ(1, array1.Int8At(4));
+  EXPECT_EQ(1, array1.Uint8At(4));
+  EXPECT_EQ(2, array1.Int8At(5));
+  EXPECT_EQ(2, array1.Uint8At(5));

[siva, 2011/11/02 17:05:31]

We probably need unit tests for get/set of other types too, maybe have a
templatized version or something to avoid having to retype this again.

[cshapiro, 2011/11/04 18:16:21]

It is not entirely clear how to do this.  I have simplified the access routine
so the getter and setter is now templatized although I think you are suggesting
a more meaningful change.

+
+  const ExternalArray& array2 =
+      ExternalArray::Handle(ExternalArray::New(data, data_length));
+  EXPECT(!array1.IsNull());
+  EXPECT_EQ(data_length, array2.Length());
+  EXPECT(array1.Equals(array2));
+  EXPECT(array2.Equals(array1));
+  array1.SetUint8At(0, 123);
+  array2.SetInt8At(2, -123);
+  EXPECT(array1.Equals(array2));
+  EXPECT(array2.Equals(array1));

[siva, 2011/11/02 17:05:31]

We should set some different values and check that array1.Equals(array2) returns
false in that case.

[cshapiro, 2011/11/04 18:16:21]

Absolutely.  Done in the more recent patch set.

+}
+
+
 TEST_CASE(Script) {
   const char* url_chars = "builtin:test-case";
   const char* source_chars = "This will not compile.";
   const String& url = String::Handle(String::New(url_chars));
   const String& source = String::Handle(String::New(source_chars));
   const Script& script = Script::Handle(Script::New(url,
                                                     source,
                                                     RawScript::kSource));
   EXPECT(!script.IsNull());
   EXPECT(script.IsScript());
@@ skipping 344 matching lines @@
     cls = iterator.GetNextClass();
     ASSERT((cls.raw() == ae66.raw()) || (cls.raw() == re44.raw()));
     count++;
   }
   ASSERT(count == 2);
 }
 
 #endif  // TARGET_ARCH_IA32.
 
 }  // namespace dart