Chromium Code Reviews| Index: chrome/common/extensions/extension_manifests_unittest.cc |
| diff --git a/chrome/common/extensions/extension_manifests_unittest.cc b/chrome/common/extensions/extension_manifests_unittest.cc |
| index 0008ef7189b40d24f448a166c01732f21bce6378..714494cdfef731b509d91abe1ae4b79625eb11eb 100644 |
| --- a/chrome/common/extensions/extension_manifests_unittest.cc |
| +++ b/chrome/common/extensions/extension_manifests_unittest.cc |
| @@ -221,16 +221,16 @@ TEST_F(ExtensionManifestTest, InitFromValueValid) { |
| // Test that an empty list of page actions does not stop a browser action |
| // from being loaded. |
| - extension = LoadAndExpectSuccess("init_valid_empty_page_actions.json"); |
| + LoadAndExpectSuccess("init_valid_empty_page_actions.json"); |
| // Test with a minimum_chrome_version. |
| - extension = LoadAndExpectSuccess("init_valid_minimum_chrome.json"); |
| + LoadAndExpectSuccess("init_valid_minimum_chrome.json"); |
| // Test a hosted app with a minimum_chrome_version. |
| - extension = LoadAndExpectSuccess("init_valid_app_minimum_chrome.json"); |
| + LoadAndExpectSuccess("init_valid_app_minimum_chrome.json"); |
| // Test a hosted app with a requirements section. |
| - extension = LoadAndExpectSuccess("init_valid_app_requirements.json"); |
| + LoadAndExpectSuccess("init_valid_app_requirements.json"); |
| // Verify empty permission settings are considered valid. |
| LoadAndExpectSuccess("init_valid_permissions_empty.json"); |
| @@ -238,6 +238,9 @@ TEST_F(ExtensionManifestTest, InitFromValueValid) { |
| // We allow unknown API permissions, so this will be valid until we better |
| // distinguish between API and host permissions. |
| LoadAndExpectSuccess("init_valid_permissions_unknown.json"); |
| + |
| + // A minimal platform app. |
| + LoadAndExpectSuccess("init_valid_platform_app.json"); |
|
Aaron Boodman
2011/11/04 05:45:16
There's probably going to be more of these app man
|
| } |
| TEST_F(ExtensionManifestTest, InitFromValueValidNameInRTL) { |
| @@ -392,6 +395,8 @@ TEST_F(ExtensionManifestTest, AppLaunchContainer) { |
| errors::kInvalidLaunchContainer); |
| LoadAndExpectError("launch_container_invalid_type.json", |
| errors::kInvalidLaunchContainer); |
| + LoadAndExpectError("launch_container_invalid_type_for_platform.json", |
| + errors::kInvalidLaunchContainerForPlatform); |
| LoadAndExpectError("launch_container_invalid_value.json", |
| errors::kInvalidLaunchContainer); |
| LoadAndExpectError("launch_container_without_launch_url.json", |